From patchwork Wed Mar 7 09:22:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Wang X-Patchwork-Id: 145170 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 77660B6EF1 for ; Wed, 7 Mar 2012 20:24:58 +1100 (EST) Received: from localhost ([::1]:51380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5D79-0002fB-Da for incoming@patchwork.ozlabs.org; Wed, 07 Mar 2012 04:24:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5D6m-0002J4-8C for qemu-devel@nongnu.org; Wed, 07 Mar 2012 04:24:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5D6M-0000sr-F5 for qemu-devel@nongnu.org; Wed, 07 Mar 2012 04:24:31 -0500 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:45385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5D6L-0000rZ-Sr for qemu-devel@nongnu.org; Wed, 07 Mar 2012 04:24:06 -0500 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Mar 2012 09:17:13 +1000 Received: from d23relay04.au.ibm.com (202.81.31.246) by e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 7 Mar 2012 09:17:09 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q279I94N3522708 for ; Wed, 7 Mar 2012 20:18:09 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q279Nj4U000501 for ; Wed, 7 Mar 2012 20:23:46 +1100 Received: from wdongxu-T410.cn.ibm.com (wdongxu-t410.cn.ibm.com [9.115.118.147] (may be forged)) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q279NfgC000428; Wed, 7 Mar 2012 20:23:44 +1100 From: Dong Xu Wang To: qemu-devel@nongnu.org Date: Wed, 7 Mar 2012 17:22:58 +0800 Message-Id: <1331112179-12726-3-git-send-email-wdongxu@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1331112179-12726-1-git-send-email-wdongxu@linux.vnet.ibm.com> References: <1331112179-12726-1-git-send-email-wdongxu@linux.vnet.ibm.com> x-cbid: 12030623-1618-0000-0000-000001028A66 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.81.31.143 Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 3/4 v2 RESEND] block: add dirty flag status to qemu-img X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Dong Xu Wang Some block drivers can verify their image files are clean or not. So we can show it while using "qemu-img info. Signed-off-by: Dong Xu Wang --- block.c | 14 ++++++++++++++ block.h | 2 ++ block_int.h | 1 + qemu-img.c | 3 +++ 4 files changed, 20 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 947607b..17e9ba8 100644 --- a/block.c +++ b/block.c @@ -193,6 +193,20 @@ static void bdrv_io_limits_intercept(BlockDriverState *bs, qemu_co_queue_next(&bs->throttled_reqs); } +/* check if the image was cleanly shut down */ +bool bdrv_not_cleanly_down(BlockDriverState *bs) +{ + BlockDriver *drv = bs->drv; + + if (!drv) { + return 0; + } + if (!drv->bdrv_not_cleanly_down) { + return 0; + } + return drv->bdrv_not_cleanly_down(bs); +} + /* check if the path starts with ":" */ static int path_has_protocol(const char *path) { diff --git a/block.h b/block.h index d76d386..00dc2a5 100644 --- a/block.h +++ b/block.h @@ -110,6 +110,8 @@ void bdrv_io_limits_enable(BlockDriverState *bs); void bdrv_io_limits_disable(BlockDriverState *bs); bool bdrv_io_limits_enabled(BlockDriverState *bs); +bool bdrv_not_cleanly_down(BlockDriverState *bs); + void bdrv_init(void); void bdrv_init_with_whitelist(void); BlockDriver *bdrv_find_protocol(const char *filename); diff --git a/block_int.h b/block_int.h index 339a5ac..e28787c 100644 --- a/block_int.h +++ b/block_int.h @@ -114,6 +114,7 @@ struct BlockDriver { int (*bdrv_create)(const char *filename, QEMUOptionParameter *options); int (*bdrv_set_key)(BlockDriverState *bs, const char *key); int (*bdrv_make_empty)(BlockDriverState *bs); + bool (*bdrv_not_cleanly_down)(BlockDriverState *bs); /* aio */ BlockDriverAIOCB *(*bdrv_aio_readv)(BlockDriverState *bs, int64_t sector_num, QEMUIOVector *qiov, int nb_sectors, diff --git a/qemu-img.c b/qemu-img.c index 17731a9..c84527b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1122,6 +1122,9 @@ static int img_info(int argc, char **argv) if (bdrv_is_encrypted(bs)) { printf("encrypted: yes\n"); } + if (bdrv_not_cleanly_down(bs)) { + printf("cleanly shut down: no\n"); + } if (bdrv_get_info(bs, &bdi) >= 0) { if (bdi.cluster_size != 0) { printf("cluster_size: %d\n", bdi.cluster_size);