From patchwork Mon Jan 16 20:09:51 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 136366 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 64CA41007D3 for ; Tue, 17 Jan 2012 07:10:21 +1100 (EST) Received: from localhost ([::1]:47836 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmssl-0005tE-4q for incoming@patchwork.ozlabs.org; Mon, 16 Jan 2012 15:10:19 -0500 Received: from eggs.gnu.org ([140.186.70.92]:40017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmssc-0005rp-E4 for qemu-devel@nongnu.org; Mon, 16 Jan 2012 15:10:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rmssb-00053A-46 for qemu-devel@nongnu.org; Mon, 16 Jan 2012 15:10:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rmssa-000533-RC for qemu-devel@nongnu.org; Mon, 16 Jan 2012 15:10:09 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0GKA6xZ029395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Jan 2012 15:10:06 -0500 Received: from localhost (ovpn-116-66.ams2.redhat.com [10.36.116.66]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0GKA1Cl019715; Mon, 16 Jan 2012 15:10:03 -0500 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Mon, 16 Jan 2012 18:09:51 -0200 Message-Id: <1326744592-27650-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1326744592-27650-1-git-send-email-lcapitulino@redhat.com> References: <1326744592-27650-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: eblake@redhat.com, jcody@redhat.com, mdroth@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 1/2] qemu-ga: set O_NONBLOCK for serial channels X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This fixes a bug when using -m isa-serial where qemu-ga will hang on a read()'s when communicating to the host via isa-serial. Original fix by Michael Roth. Signed-off-by: Luiz Capitulino --- qemu-ga.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index 29e4f64..647df82 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -504,7 +504,7 @@ static void init_guest_agent(GAState *s) exit(EXIT_FAILURE); } } else if (strcmp(s->method, "isa-serial") == 0) { - fd = qemu_open(s->path, O_RDWR | O_NOCTTY); + fd = qemu_open(s->path, O_RDWR | O_NOCTTY | O_NONBLOCK); if (fd == -1) { g_critical("error opening channel: %s", strerror(errno)); exit(EXIT_FAILURE);