From patchwork Wed Jan 4 19:45:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 134334 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 72AD31007D6 for ; Thu, 5 Jan 2012 06:45:54 +1100 (EST) Received: from localhost ([::1]:39804 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiWmP-0002v0-E4 for incoming@patchwork.ozlabs.org; Wed, 04 Jan 2012 14:45:45 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiWm6-0002Wx-Ql for qemu-devel@nongnu.org; Wed, 04 Jan 2012 14:45:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiWm4-0005pc-EC for qemu-devel@nongnu.org; Wed, 04 Jan 2012 14:45:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiWm3-0005pI-TB for qemu-devel@nongnu.org; Wed, 04 Jan 2012 14:45:24 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q04JjLYB027912 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 4 Jan 2012 14:45:21 -0500 Received: from localhost (ovpn-113-123.phx2.redhat.com [10.3.113.123]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q04JjKhD008779; Wed, 4 Jan 2012 14:45:20 -0500 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Wed, 4 Jan 2012 17:45:12 -0200 Message-Id: <1325706313-21936-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1325706313-21936-1-git-send-email-lcapitulino@redhat.com> References: <1325706313-21936-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 209.132.183.28 Cc: amit.shah@redhat.com, jcody@redhat.com, mdroth@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 1/2] qemu-ga: set O_NONBLOCK for serial channels X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This fixes a bug when using -m isa-serial where qemu-ga will hang on a read()'s when communicating to the host via isa-serial. Original fix by Michael Roth. Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth --- qemu-ga.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index 200bb15..98e4dfe 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -504,7 +504,7 @@ static void init_guest_agent(GAState *s) exit(EXIT_FAILURE); } } else if (strcmp(s->method, "isa-serial") == 0) { - fd = qemu_open(s->path, O_RDWR | O_NOCTTY); + fd = qemu_open(s->path, O_RDWR | O_NOCTTY | O_NONBLOCK); if (fd == -1) { g_critical("error opening channel: %s", strerror(errno)); exit(EXIT_FAILURE);