| Message ID | 1325706313-21936-2-git-send-email-lcapitulino@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 01/04/2012 01:45 PM, Luiz Capitulino wrote: > This fixes a bug when using -m isa-serial where qemu-ga will > hang on a read()'s when communicating to the host via isa-serial. > > Original fix by Michael Roth. > > Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com> > --- > qemu-ga.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-ga.c b/qemu-ga.c > index 200bb15..98e4dfe 100644 > --- a/qemu-ga.c > +++ b/qemu-ga.c > @@ -504,7 +504,7 @@ static void init_guest_agent(GAState *s) > exit(EXIT_FAILURE); > } > } else if (strcmp(s->method, "isa-serial") == 0) { > - fd = qemu_open(s->path, O_RDWR | O_NOCTTY); > + fd = qemu_open(s->path, O_RDWR | O_NOCTTY | O_NONBLOCK); > if (fd == -1) { > g_critical("error opening channel: %s", strerror(errno)); > exit(EXIT_FAILURE); Thanks for sending this. Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
diff --git a/qemu-ga.c b/qemu-ga.c index 200bb15..98e4dfe 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -504,7 +504,7 @@ static void init_guest_agent(GAState *s) exit(EXIT_FAILURE); } } else if (strcmp(s->method, "isa-serial") == 0) { - fd = qemu_open(s->path, O_RDWR | O_NOCTTY); + fd = qemu_open(s->path, O_RDWR | O_NOCTTY | O_NONBLOCK); if (fd == -1) { g_critical("error opening channel: %s", strerror(errno)); exit(EXIT_FAILURE);
This fixes a bug when using -m isa-serial where qemu-ga will hang on a read()'s when communicating to the host via isa-serial. Original fix by Michael Roth. Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- qemu-ga.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)