From patchwork Thu Dec 22 11:12:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 132819 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B6D9AB714F for ; Thu, 22 Dec 2011 22:12:34 +1100 (EST) Received: from localhost ([::1]:40801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdgZL-0005eE-47 for incoming@patchwork.ozlabs.org; Thu, 22 Dec 2011 06:12:15 -0500 Received: from eggs.gnu.org ([140.186.70.92]:51163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdgZ1-0005Iq-LU for qemu-devel@nongnu.org; Thu, 22 Dec 2011 06:11:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RdgYt-0002ns-NH for qemu-devel@nongnu.org; Thu, 22 Dec 2011 06:11:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RdgYt-0002nd-Cq for qemu-devel@nongnu.org; Thu, 22 Dec 2011 06:11:47 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBMBBkrb003189 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 22 Dec 2011 06:11:46 -0500 Received: from shalem.localdomain.com (vpn1-7-171.ams2.redhat.com [10.36.7.171]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pBMBBeUi009053; Thu, 22 Dec 2011 06:11:45 -0500 From: Hans de Goede To: Gerd Hoffmann Date: Thu, 22 Dec 2011 12:12:38 +0100 Message-Id: <1324552358-5234-5-git-send-email-hdegoede@redhat.com> In-Reply-To: <1324552358-5234-1-git-send-email-hdegoede@redhat.com> References: <1324552358-5234-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 209.132.183.28 Cc: Hans de Goede , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 5/5] usb-redir: Improve some debugging messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Hans de Goede --- usb-redir.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/usb-redir.c b/usb-redir.c index 4fada22..1289506 100644 --- a/usb-redir.c +++ b/usb-redir.c @@ -404,7 +404,8 @@ static int usbredir_handle_iso_data(USBRedirDevice *dev, USBPacket *p, /* No id, we look at the ep when receiving a status back */ usbredirparser_send_start_iso_stream(dev->parser, 0, &start_iso); usbredirparser_do_write(dev->parser); - DPRINTF("iso stream started ep %02X\n", ep); + DPRINTF("iso stream started pkts/sec %d pkts/urb %d urbs %d ep %02X\n", + pkts_per_sec, start_iso.pkts_per_urb, start_iso.no_urbs, ep); dev->endpoint[EP2I(ep)].iso_started = 1; dev->endpoint[EP2I(ep)].bufpq_prefilled = 0; dev->endpoint[EP2I(ep)].bufpq_dropping_packets = 0; @@ -424,7 +425,8 @@ static int usbredir_handle_iso_data(USBRedirDevice *dev, USBPacket *p, isop = QTAILQ_FIRST(&dev->endpoint[EP2I(ep)].bufpq); if (isop == NULL) { - DPRINTF2("iso-token-in ep %02X, no isop\n", ep); + DPRINTF("iso-token-in ep %02X, no isop, iso_error: %d\n", + ep, dev->endpoint[EP2I(ep)].iso_error); /* Re-fill the buffer */ dev->endpoint[EP2I(ep)].bufpq_prefilled = 0; /* Check iso_error for stream errors, otherwise its an underrun */ @@ -432,8 +434,8 @@ static int usbredir_handle_iso_data(USBRedirDevice *dev, USBPacket *p, dev->endpoint[EP2I(ep)].iso_error = 0; return usbredir_handle_status(dev, status, 0); } - DPRINTF2("iso-token-in ep %02X status %d len %d\n", ep, isop->status, - isop->len); + DPRINTF2("iso-token-in ep %02X status %d len %d queue-size: %d\n", ep, + isop->status, isop->len, dev->endpoint[EP2I(ep)].bufpq_size); status = isop->status; if (status != usb_redir_success) { @@ -443,7 +445,8 @@ static int usbredir_handle_iso_data(USBRedirDevice *dev, USBPacket *p, len = isop->len; if (len > p->iov.size) { - ERROR("received iso data is larger then packet ep %02X\n", ep); + ERROR("received iso data is larger then packet ep %02X (%d > %d)\n", + ep, len, (int)p->iov.size); bufp_free(dev, isop, ep); return USB_RET_NAK; }