From patchwork Sat Nov 19 09:22:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 126533 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id C7797B7236 for ; Sat, 19 Nov 2011 20:23:29 +1100 (EST) Received: from localhost ([::1]:44882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRh8w-0001p7-Lp for incoming@patchwork.ozlabs.org; Sat, 19 Nov 2011 04:23:26 -0500 Received: from eggs.gnu.org ([140.186.70.92]:34108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRh7v-0007pm-GB for qemu-devel@nongnu.org; Sat, 19 Nov 2011 04:22:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRh7u-0008Bd-F7 for qemu-devel@nongnu.org; Sat, 19 Nov 2011 04:22:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRh7u-0008BP-5w for qemu-devel@nongnu.org; Sat, 19 Nov 2011 04:22:22 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAJ9MKCs025263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 19 Nov 2011 04:22:20 -0500 Received: from shalem.localdomain.com (vpn1-6-161.ams2.redhat.com [10.36.6.161]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pAJ9MCq3032695; Sat, 19 Nov 2011 04:22:19 -0500 From: Hans de Goede To: Gerd Hoffmann Date: Sat, 19 Nov 2011 10:22:47 +0100 Message-Id: <1321694567-2855-6-git-send-email-hdegoede@redhat.com> In-Reply-To: <1321694567-2855-1-git-send-email-hdegoede@redhat.com> References: <1321694567-2855-1-git-send-email-hdegoede@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 209.132.183.28 Cc: Hans de Goede , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 5/5] usb-redir: Don't try to write to the chardev after a close event X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Since we handle close async in a bh, do_write and thus write can get called after receiving a close event. This patch adds a check to the usb-redir write callback to not call qemu_chr_fe_write on a closed backend. Signed-off-by: Hans de Goede --- usb-redir.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/usb-redir.c b/usb-redir.c index 24fdd31..fb91c92 100644 --- a/usb-redir.c +++ b/usb-redir.c @@ -225,6 +225,10 @@ static int usbredir_write(void *priv, uint8_t *data, int count) { USBRedirDevice *dev = priv; + if (!dev->cs->opened) { + return 0; + } + return qemu_chr_fe_write(dev->cs, data, count); }