From patchwork Thu Nov 17 17:18:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 126283 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8819BB720D for ; Fri, 18 Nov 2011 04:18:48 +1100 (EST) Received: from localhost ([::1]:42333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR5bm-0001Hj-0C for incoming@patchwork.ozlabs.org; Thu, 17 Nov 2011 12:18:42 -0500 Received: from eggs.gnu.org ([140.186.70.92]:46828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR5bc-0001BU-Lz for qemu-devel@nongnu.org; Thu, 17 Nov 2011 12:18:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RR5bb-0004MZ-Ki for qemu-devel@nongnu.org; Thu, 17 Nov 2011 12:18:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RR5bb-0004MO-De for qemu-devel@nongnu.org; Thu, 17 Nov 2011 12:18:31 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAHHIUjY016449 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 Nov 2011 12:18:30 -0500 Received: from localhost (ovpn-113-151.phx2.redhat.com [10.3.113.151]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pAHHITs7018149; Thu, 17 Nov 2011 12:18:30 -0500 From: Luiz Capitulino To: aliguori@us.ibm.com Date: Thu, 17 Nov 2011 15:18:17 -0200 Message-Id: <1321550301-11953-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1321550301-11953-1-git-send-email-lcapitulino@redhat.com> References: <1321550301-11953-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 209.132.183.28 Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 1/5] qapi: Check for negative enum values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We don't currently check for negative enum values in qmp_output_type_enum(), this will very likely generate a segfault when triggered. However, it _seems_ that no code in tree can trigger this today. Acked-by: Michael Roth Signed-off-by: Luiz Capitulino --- qapi/qmp-output-visitor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qapi/qmp-output-visitor.c b/qapi/qmp-output-visitor.c index d67724e..f76d015 100644 --- a/qapi/qmp-output-visitor.c +++ b/qapi/qmp-output-visitor.c @@ -190,7 +190,7 @@ static void qmp_output_type_enum(Visitor *v, int *obj, const char *strings[], assert(strings); while (strings[i++] != NULL); - if (value >= i - 1) { + if (value < 0 || value >= i - 1) { error_set(errp, QERR_INVALID_PARAMETER, name ? name : "null"); return; }