Message ID | 131d9e66f5046317565c7d17af65823ebebb4b50.1504112061.git.jcody@redhat.com |
---|---|
State | New |
Headers | show |
Series | Code cleanup and minor fixes | expand |
On 08/30/2017 11:57 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody <jcody@redhat.com> > --- > block/curl.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > +++ b/block/curl.c > @@ -857,6 +857,9 @@ out_noclean: > qemu_mutex_destroy(&s->mutex); > g_free(s->cookie); > g_free(s->url); > + g_free(s->username); > + g_free(s->proxyusername); > + g_free(s->proxypassword); Would it be any simpler to call curl_close(s) instead of open-coding it here in this cleanup path? > @@ -955,6 +958,9 @@ static void curl_close(BlockDriverState *bs) > > g_free(s->cookie); > g_free(s->url); > + g_free(s->username); > + g_free(s->proxyusername); > + g_free(s->proxypassword); > } Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/block/curl.c b/block/curl.c index 00a9879..35cf417 100644 --- a/block/curl.c +++ b/block/curl.c @@ -857,6 +857,9 @@ out_noclean: qemu_mutex_destroy(&s->mutex); g_free(s->cookie); g_free(s->url); + g_free(s->username); + g_free(s->proxyusername); + g_free(s->proxypassword); qemu_opts_del(opts); return -EINVAL; } @@ -955,6 +958,9 @@ static void curl_close(BlockDriverState *bs) g_free(s->cookie); g_free(s->url); + g_free(s->username); + g_free(s->proxyusername); + g_free(s->proxypassword); } static int64_t curl_getlength(BlockDriverState *bs)
Signed-off-by: Jeff Cody <jcody@redhat.com> --- block/curl.c | 6 ++++++ 1 file changed, 6 insertions(+)