From patchwork Wed Oct 19 12:56:48 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 120631 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EC85FB71D1 for ; Thu, 20 Oct 2011 00:41:07 +1100 (EST) Received: from localhost ([::1]:58953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGViM-0008U2-6P for incoming@patchwork.ozlabs.org; Wed, 19 Oct 2011 08:57:46 -0400 Received: from eggs.gnu.org ([140.186.70.92]:46551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGVhf-0007Fw-Np for qemu-devel@nongnu.org; Wed, 19 Oct 2011 08:57:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGVhe-0007nx-7M for qemu-devel@nongnu.org; Wed, 19 Oct 2011 08:57:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGVhd-0007nl-T9 for qemu-devel@nongnu.org; Wed, 19 Oct 2011 08:57:02 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9JCuxSn004644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Oct 2011 08:56:59 -0400 Received: from localhost (ovpn-113-110.phx2.redhat.com [10.3.113.110]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9JCuwsj007610; Wed, 19 Oct 2011 08:56:58 -0400 From: Luiz Capitulino To: aliguori@us.ibm.com Date: Wed, 19 Oct 2011 10:56:48 -0200 Message-Id: <1319029011-11706-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1319029011-11706-1-git-send-email-lcapitulino@redhat.com> References: <1319029011-11706-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 209.132.183.28 Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 2/5] runstate: Print state transition when invalid X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Makes it easier to debug. Signed-off-by: Luiz Capitulino --- vl.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 2dce3ae..2a634a7 100644 --- a/vl.c +++ b/vl.c @@ -393,9 +393,12 @@ void runstate_init(void) /* This function will abort() on invalid state transitions */ void runstate_set(RunState new_state) { - if (new_state >= RUN_STATE_MAX || - !runstate_valid_transitions[current_run_state][new_state]) { - fprintf(stderr, "invalid runstate transition\n"); + assert(new_state < RUN_STATE_MAX); + + if (!runstate_valid_transitions[current_run_state][new_state]) { + fprintf(stderr, "ERROR: invalid runstate transition: '%s' -> '%s'\n", + RunState_lookup[current_run_state], + RunState_lookup[new_state]); abort(); }