| Message ID | 1315153802-24346-1-git-send-email-weil@mail.berlios.de |
|---|---|
| State | Accepted |
| Headers | show |
On Sun, Sep 04, 2011 at 06:30:02PM +0200, Stefan Weil wrote: > This patch removes redundant shell code and cleans it a little bit. > > Shell macro compile_prog takes two arguments: > local_cflags and local ldflags. > > $QEMU_CFLAGS is added automatically to the cflags, so there is no need > to pass it as an argument. > > It is also unnecessary to pass -Werror twice. > > $flag is a compiler warning option, so it should be in local_cflags > instead of local_ldflags. > > Signed-off-by: Stefan Weil <weil@mail.berlios.de> > --- > configure | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches -next tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next Stefan
diff --git a/configure b/configure index c3044c7..d261fdd 100755 --- a/configure +++ b/configure @@ -1071,7 +1071,7 @@ cat > $TMPC << EOF int main(void) { return 0; } EOF for flag in $gcc_flags; do - if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then + if compile_prog "$flag -Werror" "" ; then QEMU_CFLAGS="$QEMU_CFLAGS $flag" fi done
This patch removes redundant shell code and cleans it a little bit. Shell macro compile_prog takes two arguments: local_cflags and local ldflags. $QEMU_CFLAGS is added automatically to the cflags, so there is no need to pass it as an argument. It is also unnecessary to pass -Werror twice. $flag is a compiler warning option, so it should be in local_cflags instead of local_ldflags. Signed-off-by: Stefan Weil <weil@mail.berlios.de> --- configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)