From patchwork Wed Jul 13 14:49:56 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 104564 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2ED79B6F67 for ; Thu, 14 Jul 2011 02:50:43 +1000 (EST) Received: from localhost ([::1]:40903 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh2dx-0006Cz-TH for incoming@patchwork.ozlabs.org; Wed, 13 Jul 2011 12:50:38 -0400 Received: from eggs.gnu.org ([140.186.70.92]:44342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh0lq-00077a-Ox for qemu-devel@nongnu.org; Wed, 13 Jul 2011 10:50:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qh0lo-00087M-2P for qemu-devel@nongnu.org; Wed, 13 Jul 2011 10:50:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qh0ln-00086q-AK for qemu-devel@nongnu.org; Wed, 13 Jul 2011 10:50:35 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6DEoYe1015025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Jul 2011 10:50:34 -0400 Received: from bow.tlv.redhat.com (dhcp-3-110.tlv.redhat.com [10.35.3.110]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6DEoGse031549; Wed, 13 Jul 2011 10:50:32 -0400 From: Alon Levy To: qemu-devel@nongnu.org Date: Wed, 13 Jul 2011 17:49:56 +0300 Message-Id: <1310568597-24181-11-git-send-email-alevy@redhat.com> In-Reply-To: <1310568597-24181-1-git-send-email-alevy@redhat.com> References: <1310568597-24181-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: yhalperi@redhat.com, kraxel@redhat.com Subject: [Qemu-devel] [PATCHv4 10/11] qxl: only disallow specific io's in vga mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. Signed-off-by: Alon Levy --- hw/qxl.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b34e8d0..5ea4c76 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1163,8 +1163,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) case QXL_IO_LOG: break; default: - if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) + if (d->mode != QXL_MODE_VGA) { break; + } dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n", __func__, io_port, io_port_to_string(io_port)); /* be nice to buggy guest drivers */