From patchwork Thu Jul 7 16:50:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 103701 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2EC84B6F54 for ; Fri, 8 Jul 2011 03:17:22 +1000 (EST) Received: from localhost ([::1]:53405 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QesCU-0006zJ-K3 for incoming@patchwork.ozlabs.org; Thu, 07 Jul 2011 13:17:18 -0400 Received: from eggs.gnu.org ([140.186.70.92]:36747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qerx2-0003P1-JX for qemu-devel@nongnu.org; Thu, 07 Jul 2011 13:01:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QernM-00081r-8A for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:51:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QernL-00081i-Ql for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:51:20 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p67GpJFf022606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Jul 2011 12:51:19 -0400 Received: from bow.redhat.com (vpn-11-30.rdu.redhat.com [10.11.11.30]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p67Gowx2012124; Thu, 7 Jul 2011 12:51:17 -0400 From: Alon Levy To: qemu-devel@nongnu.org Date: Thu, 7 Jul 2011 18:50:52 +0200 Message-Id: <1310057455-18570-12-git-send-email-alevy@redhat.com> In-Reply-To: <1310057455-18570-1-git-send-email-alevy@redhat.com> References: <1310057455-18570-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: yhalperi@redhat.com, kraxel@redhat.com Subject: [Qemu-devel] [PATCH v2] qxl: only disallow specific io's in vga mode X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Since the driver is still in operation even after moving to UNDEFINED, i.e. by destroying primary in any way. --- hw/qxl.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 395d994..e57ccf2 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1167,8 +1167,9 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val) case QXL_IO_LOG: break; default: - if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) + if (d->mode != QXL_MODE_VGA) { break; + } dprint(d, 1, "%s: unexpected port 0x%x (%s) in vga mode\n", __FUNCTION__, io_port, io_port_to_string(io_port)); /* be nice to buggy guest drivers */