From patchwork Fri Jul 1 13:46:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 102909 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 733BDB6F59 for ; Sat, 2 Jul 2011 00:50:18 +1000 (EST) Received: from localhost ([::1]:51483 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qcf2r-0005WM-E0 for incoming@patchwork.ozlabs.org; Fri, 01 Jul 2011 10:50:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]:51999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qce36-0007rH-Fv for qemu-devel@nongnu.org; Fri, 01 Jul 2011 09:46:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qce32-0003Yx-Pr for qemu-devel@nongnu.org; Fri, 01 Jul 2011 09:46:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qce32-0003Yc-7s for qemu-devel@nongnu.org; Fri, 01 Jul 2011 09:46:20 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p61DkJVx016917 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 1 Jul 2011 09:46:19 -0400 Received: from localhost (ovpn-113-102.phx2.redhat.com [10.3.113.102]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p61DkIDH021788; Fri, 1 Jul 2011 09:46:18 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Fri, 1 Jul 2011 10:46:13 -0300 Message-Id: <1309527973-11127-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1309527973-11127-1-git-send-email-lcapitulino@redhat.com> References: <1309527973-11127-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, armbru@redhat.com Subject: [Qemu-devel] [PATCH 2/2] block: drive_init(): Improve CHS setting error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The current message doesn't clearly communicate the error cause. Signed-off-by: Luiz Capitulino --- blockdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 470be71..a97a801 100644 --- a/blockdev.c +++ b/blockdev.c @@ -310,7 +310,7 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) media = MEDIA_DISK; } else if (!strcmp(buf, "cdrom")) { if (cyls || secs || heads) { - error_report("'%s' invalid physical CHS format", buf); + error_report("CHS can't be set with media=%s", buf); return NULL; } media = MEDIA_CDROM;