From patchwork Wed Apr 13 23:11:03 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 91135 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0408EB6F4F for ; Thu, 14 Apr 2011 09:15:56 +1000 (EST) Received: from localhost ([::1]:56687 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA9Ht-0001FG-51 for incoming@patchwork.ozlabs.org; Wed, 13 Apr 2011 19:15:53 -0400 Received: from eggs.gnu.org ([140.186.70.92]:57097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA9De-0002KB-1K for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QA9Dc-000524-K0 for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:29 -0400 Received: from hall.aurel32.net ([88.191.126.93]:56707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA9Dc-0004y9-E9 for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:28 -0400 Received: from [2001:470:d4ed:0:5e26:aff:fe2b:6f5b] (helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1QA9DU-0001hB-DA; Thu, 14 Apr 2011 01:11:20 +0200 Received: from aurel32 by volta.aurel32.net with local (Exim 4.72) (envelope-from ) id 1QA9DQ-00016V-DY; Thu, 14 Apr 2011 01:11:16 +0200 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Thu, 14 Apr 2011 01:11:03 +0200 Message-Id: <1302736274-2908-9-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1302736274-2908-1-git-send-email-aurelien@aurel32.net> References: <1302736274-2908-1-git-send-email-aurelien@aurel32.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 88.191.126.93 Cc: Aurelien Jarno Subject: [Qemu-devel] [PATCH v2 08/19] target-alpha: use new float64_unordered_quiet() function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Use float64_unordered_quiet() in helper_cmptun() instead of doing the the comparison manually. According to the "Alpha Compiler Writer's Guide", we should use the _quiet version here, as CMPTUN and CMPTEQ should generate InvalidOp for SNaNs but not for QNaNs. Thanks to Peter Maydell and Richard Henderson for digging into the manuals. Signed-off-by: Aurelien Jarno Acked-by: Richard Henderson --- target-alpha/op_helper.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) v2: use float64_unordered_quiet() instead of float64_unordered() diff --git a/target-alpha/op_helper.c b/target-alpha/op_helper.c index 6c2ae20..36f4f6d 100644 --- a/target-alpha/op_helper.c +++ b/target-alpha/op_helper.c @@ -904,10 +904,11 @@ uint64_t helper_cmptun (uint64_t a, uint64_t b) fa = t_to_float64(a); fb = t_to_float64(b); - if (float64_is_quiet_nan(fa) || float64_is_quiet_nan(fb)) + if (float64_unordered_quiet(fa, fb, &FP_STATUS)) { return 0x4000000000000000ULL; - else + } else { return 0; + } } uint64_t helper_cmpteq(uint64_t a, uint64_t b)