From patchwork Wed Apr 13 23:10:58 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aurelien Jarno X-Patchwork-Id: 91133 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2EA8BB6F4F for ; Thu, 14 Apr 2011 09:15:01 +1000 (EST) Received: from localhost ([::1]:35285 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA9Gz-0007x0-7F for incoming@patchwork.ozlabs.org; Wed, 13 Apr 2011 19:14:57 -0400 Received: from eggs.gnu.org ([140.186.70.92]:57121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA9Df-0002MO-Le for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QA9Da-0004zN-IN for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:31 -0400 Received: from hall.aurel32.net ([88.191.126.93]:56702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA9Da-0004xt-Aw for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:26 -0400 Received: from [2001:470:d4ed:0:5e26:aff:fe2b:6f5b] (helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1QA9DQ-0001h3-Jy; Thu, 14 Apr 2011 01:11:16 +0200 Received: from aurel32 by volta.aurel32.net with local (Exim 4.72) (envelope-from ) id 1QA9DP-00016E-J7; Thu, 14 Apr 2011 01:11:15 +0200 From: Aurelien Jarno To: qemu-devel@nongnu.org Date: Thu, 14 Apr 2011 01:10:58 +0200 Message-Id: <1302736274-2908-4-git-send-email-aurelien@aurel32.net> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1302736274-2908-1-git-send-email-aurelien@aurel32.net> References: <1302736274-2908-1-git-send-email-aurelien@aurel32.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 88.191.126.93 Cc: Laurent Vivier , Aurelien Jarno Subject: [Qemu-devel] [PATCH v2 03/19] target-i386: use CPU_LDoubleU instead of a private union X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Use CPU_LDoubleU in cpu_dump_state() instead of redefining a union for doing the conversion. Based on a patch from Laurent Vivier . Cc: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Aurelien Jarno --- target-i386/helper.c | 12 +++--------- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index d15fca5..89df997 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -404,16 +404,10 @@ void cpu_dump_state(CPUState *env, FILE *f, fprintf_function cpu_fprintf, env->mxcsr); for(i=0;i<8;i++) { #if defined(USE_X86LDOUBLE) - union { - long double d; - struct { - uint64_t lower; - uint16_t upper; - } l; - } tmp; - tmp.d = env->fpregs[i].d; + CPU_LDoubleU u; + u.d = env->fpregs[i].d; cpu_fprintf(f, "FPR%d=%016" PRIx64 " %04x", - i, tmp.l.lower, tmp.l.upper); + i, u.l.lower, u.l.upper); #else cpu_fprintf(f, "FPR%d=%016" PRIx64, i, env->fpregs[i].mmx.q);