From patchwork Wed Mar 30 12:31:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 88918 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 32D24B6EFE for ; Wed, 30 Mar 2011 23:32:30 +1100 (EST) Received: from localhost ([127.0.0.1]:36037 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4uZX-0002Np-AL for incoming@patchwork.ozlabs.org; Wed, 30 Mar 2011 08:32:27 -0400 Received: from [140.186.70.92] (port=36300 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4uYf-0002B3-0g for qemu-devel@nongnu.org; Wed, 30 Mar 2011 08:31:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4uYd-0002zF-R1 for qemu-devel@nongnu.org; Wed, 30 Mar 2011 08:31:32 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:47139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4uYd-0002ys-KZ for qemu-devel@nongnu.org; Wed, 30 Mar 2011 08:31:31 -0400 Received: from gandalf.tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id F0D4FA4B20; Wed, 30 Mar 2011 16:31:28 +0400 (MSD) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 87B1713362; Wed, 30 Mar 2011 16:31:27 +0400 (MSD) From: Michael Tokarev To: Kevin Wolf Date: Wed, 30 Mar 2011 16:31:05 +0400 Message-Id: <1301488265-22028-1-git-send-email-mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.2.5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 86.62.121.231 Cc: Michael Tokarev , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] exit if -drive specified is invalid instead of ignoring the "wrong" -drive X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This fixes the problem when qemu continues even if -drive specification is somehow invalid, resulting in a mess. Applicable for both current master and for stable-0.14 (and the same issue exist 0.13 and 0.12 too). The prob can actually be seriuos: when you start guest with two drives and make an error in the specification of one of them, and the guest has something like a raid array on the two drives, guest may start failing that array or kick "missing" drives which may result in a mess - this is what actually happened to me, I did't want a resync at all, and a resync resulted in re-writing (and allocating) a 4TB virtual drive I used for testing, which in turn resulted in my filesystem filling up and whole thing failing badly. Yes it was just testing VM, I experimented with larger raid arrays, but the end result was quite, well, unexpected. Signed-off-by: Michael Tokarev Acked-by: Jes Sorensen --- vl.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 8bcf2ae..3792afb 100644 --- a/vl.c +++ b/vl.c @@ -2098,7 +2098,9 @@ int main(int argc, char **argv, char **envp) HD_OPTS); break; case QEMU_OPTION_drive: - drive_def(optarg); + if (drive_def(optarg) == NULL) { + exit(1); + } break; case QEMU_OPTION_set: if (qemu_set_option(optarg) != 0)