From patchwork Mon Feb 28 09:10:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 84762 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D64B7B7130 for ; Mon, 28 Feb 2011 21:00:28 +1100 (EST) Received: from localhost ([127.0.0.1]:59894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ptzts-0002cT-Nb for incoming@patchwork.ozlabs.org; Mon, 28 Feb 2011 05:00:20 -0500 Received: from [140.186.70.92] (port=45392 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PtzEk-0005xv-OU for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:17:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ptz8O-0004lF-OL for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:11:17 -0500 Received: from mail-yx0-f173.google.com ([209.85.213.173]:62213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ptz8O-0004hM-Ko for qemu-devel@nongnu.org; Mon, 28 Feb 2011 04:11:16 -0500 Received: by mail-yx0-f173.google.com with SMTP id 8so1800210yxk.4 for ; Mon, 28 Feb 2011 01:11:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:from:to:cc:subject:date:message-id :x-mailer:in-reply-to:references; bh=9/oKwnRxR0o8Icg8v0z5lHruY0gAIbyWzZckWqulvCg=; b=ssmeBPIeb6JQkPgIQUXrQRA46OgXBRf01JFAQO+9DZnicKYqQIEyogpHsupZRgBtcc ehHrhNgxSn0f5uQO9n7imNPOGEOhgEzq8mqB3L9o4+rVPZuTGhCIADS96X8DqvDyuX4W aLL8uvQN70hkIGHO5V5cPxlUGoJS+fMMcXNGs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; b=h1jKrCB4Lr6IWHHYvXrudbkeiHB24LG1ijdBiUiubRoHcjmOYaOtROOhu7Ge+/DOwK rGXMoBBV+KJBsCzcrGlEt3D/t3haU0G9zV9XLMpn6mDEUImxhXW+CWopOjJXkvCp6ekw U1M+nRZtZinLw1KIGO/NG1lpAC/XnQMoce54g= Received: by 10.236.103.133 with SMTP id f5mr9218569yhg.14.1298884276532; Mon, 28 Feb 2011 01:11:16 -0800 (PST) Received: from localhost.localdomain (93-34-149-100.ip50.fastwebnet.it [93.34.149.100]) by mx.google.com with ESMTPS id 1sm2037209yhl.11.2011.02.28.01.11.14 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Feb 2011 01:11:16 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 28 Feb 2011 10:10:18 +0100 Message-Id: <1298884224-19734-17-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.4 In-Reply-To: <1298884224-19734-1-git-send-email-pbonzini@redhat.com> References: <1298884224-19734-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.213.173 Cc: blauwirbel@gmail.com, jan.kiszka@siemes.com, aurelien@aurel32.net, kvm@vger.kernel.org, mtosatti@redhat.com Subject: [Qemu-devel] [PATCH v3 uq/master 16/22] do not use timedwait on qemu_pause_cond X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org all_vcpus_paused can start returning true after penv->stopped changes from 0 to 1. When this is done, qemu_pause_cond is always signaled. Signed-off-by: Paolo Bonzini --- cpus.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index e367b3b..8f169ad 100644 --- a/cpus.c +++ b/cpus.c @@ -938,7 +938,7 @@ void pause_all_vcpus(void) } while (!all_vcpus_paused()) { - qemu_cond_timedwait(&qemu_pause_cond, &qemu_global_mutex, 100); + qemu_cond_wait(&qemu_pause_cond, &qemu_global_mutex); penv = first_cpu; while (penv) { qemu_cpu_kick(penv);