| Message ID | 1296155915-15796-1-git-send-email-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Thu, Jan 27, 2011 at 07:18:35PM +0000, Peter Maydell wrote: > From: Juha Riihimäki <juha.riihimaki@nokia.com> > > Correct an error in the implementation of the 16 bit > forms of VQ(R)DMULH, bringing them into line with the > 32 bit implementation. > > Signed-off-by: Juha Riihimäki <juha.riihimaki@nokia.com> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > --- > target-arm/neon_helper.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Thanks, applied. > diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c > index 20f3c16..fead152 100644 > --- a/target-arm/neon_helper.c > +++ b/target-arm/neon_helper.c > @@ -880,8 +880,9 @@ uint32_t HELPER(neon_cnt_u8)(uint32_t x) > if ((tmp ^ (tmp << 1)) & SIGNBIT) { \ > SET_QC(); \ > tmp = (tmp >> 31) ^ ~SIGNBIT; \ > + } else { \ > + tmp <<= 1; \ > } \ > - tmp <<= 1; \ > if (round) { \ > int32_t old = tmp; \ > tmp += 1 << 15; \ > -- > 1.7.1 > > >
diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c index 20f3c16..fead152 100644 --- a/target-arm/neon_helper.c +++ b/target-arm/neon_helper.c @@ -880,8 +880,9 @@ uint32_t HELPER(neon_cnt_u8)(uint32_t x) if ((tmp ^ (tmp << 1)) & SIGNBIT) { \ SET_QC(); \ tmp = (tmp >> 31) ^ ~SIGNBIT; \ + } else { \ + tmp <<= 1; \ } \ - tmp <<= 1; \ if (round) { \ int32_t old = tmp; \ tmp += 1 << 15; \