From patchwork Mon Dec 6 14:43:51 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 74376 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id ECC6FB70E2 for ; Tue, 7 Dec 2010 01:55:09 +1100 (EST) Received: from localhost ([127.0.0.1]:40988 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPcT0-0000xn-B6 for incoming@patchwork.ozlabs.org; Mon, 06 Dec 2010 09:55:02 -0500 Received: from [140.186.70.92] (port=53742 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPcIZ-0003br-8d for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:44:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPcIX-00058k-Qg for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:44:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPcIX-00058T-Jl for qemu-devel@nongnu.org; Mon, 06 Dec 2010 09:44:13 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB6Ei59G002049 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 6 Dec 2010 09:44:05 -0500 Received: from localhost ([10.3.113.17]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oB6Ei4PH015601; Mon, 6 Dec 2010 09:44:04 -0500 From: Luiz Capitulino To: anthony@codemonkey.ws Date: Mon, 6 Dec 2010 12:43:51 -0200 Message-Id: <1291646631-4609-5-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1291646631-4609-1-git-send-email-lcapitulino@redhat.com> References: <1291646631-4609-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org, Wen Congyang Subject: [Qemu-devel] [PATCH 4/4] correct migrate_set_speed's args_type X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Wen Congyang The args_type of migrate_set_speed in qmp-commands.hx is wrong. When we set migrate speed by json, qemu will be core dumped. This bug was caused by 07de3e60b05 and hence affects master only. Signed-off-by: Wen Congyang Signed-off-by: Luiz Capitulino --- qmp-commands.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index e5f157f..3486223 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -495,7 +495,7 @@ EQMP { .name = "migrate_set_speed", - .args_type = "value:f", + .args_type = "value:o", .params = "value", .help = "set maximum speed (in bytes) for migrations", .user_print = monitor_user_noop,