From patchwork Fri Oct 1 18:19:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 66509 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CC846B70E6 for ; Sat, 2 Oct 2010 05:57:07 +1000 (EST) Received: from localhost ([127.0.0.1]:47085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1kS8-0007Di-HW for incoming@patchwork.ozlabs.org; Fri, 01 Oct 2010 14:35:28 -0400 Received: from [140.186.70.92] (port=49610 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1kDh-0006Ht-Ll for qemu-devel@nongnu.org; Fri, 01 Oct 2010 14:21:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P1kDD-0003NB-Fa for qemu-devel@nongnu.org; Fri, 01 Oct 2010 14:20:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P1kDD-0003N3-7A for qemu-devel@nongnu.org; Fri, 01 Oct 2010 14:20:03 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o91IK2tg020034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Oct 2010 14:20:02 -0400 Received: from localhost (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o91IK1wL027898; Fri, 1 Oct 2010 14:20:01 -0400 From: Luiz Capitulino To: aliguori@us.ibm.com Date: Fri, 1 Oct 2010 15:19:18 -0300 Message-Id: <1285957167-1228-15-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1285957167-1228-1-git-send-email-lcapitulino@redhat.com> References: <1285957167-1228-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 14/23] QMP: Simplify do_info_commands() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org We now iterate over QMP's dispatch tables, no need to check for QMP-only handlers anymore. Signed-off-by: Luiz Capitulino --- monitor.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index bf5da50..612ee56 100644 --- a/monitor.c +++ b/monitor.c @@ -749,18 +749,13 @@ static void do_info_commands(Monitor *mon, QObject **ret_data) cmd_list = qlist_new(); for (cmd = qmp_cmds; cmd->name != NULL; cmd++) { - if (monitor_handler_ported(cmd) && !monitor_cmd_user_only(cmd) && - !compare_cmd(cmd->name, "info")) { - qlist_append_obj(cmd_list, get_cmd_dict(cmd->name)); - } + qlist_append_obj(cmd_list, get_cmd_dict(cmd->name)); } for (cmd = qmp_query_cmds; cmd->name != NULL; cmd++) { - if (monitor_handler_ported(cmd) && !monitor_cmd_user_only(cmd)) { - char buf[128]; - snprintf(buf, sizeof(buf), "query-%s", cmd->name); - qlist_append_obj(cmd_list, get_cmd_dict(buf)); - } + char buf[128]; + snprintf(buf, sizeof(buf), "query-%s", cmd->name); + qlist_append_obj(cmd_list, get_cmd_dict(buf)); } *ret_data = QOBJECT(cmd_list);