| Message ID | 1271797792-24571-13-git-send-email-lcapitulino@redhat.com |
|---|---|
| State | New |
| Headers | show |
Luiz Capitulino <lcapitulino@redhat.com> wrote: > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> VMState already used for two things in qemu, but I think that changing to StateVM _only_ on the error messages is wrong. Leave it as vmstate, and if rest of things get ever changed, change just everything? > --- > qerror.c | 4 ++++ > qerror.h | 3 +++ > 2 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/qerror.c b/qerror.c > index aa6892d..95c1a95 100644 > --- a/qerror.c > +++ b/qerror.c > @@ -197,6 +197,10 @@ static const QErrorStringTable qerror_table[] = { > .desc = "No block device can accept snapshots", > }, > { > + .error_fmt = QERR_STATEVM_SAVE_FAILED, > + .desc = "Failed to save VM state (%(reason))", > + }, > + { > .error_fmt = QERR_TOO_MANY_FILES, > .desc = "Too many open files", > }, > diff --git a/qerror.h b/qerror.h > index 4a056b3..b915e26 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -163,6 +163,9 @@ QError *qobject_to_qerror(const QObject *obj); > #define QERR_SNAPSHOT_NO_DEVICE \ > "{ 'class': 'SnapshotNoDevice', 'data': {} }" > > +#define QERR_STATEVM_SAVE_FAILED \ > + "{ 'class': 'StateVmSaveFailed', 'data': { 'reason': %s } }" > + > #define QERR_TOO_MANY_FILES \ > "{ 'class': 'TooManyFiles', 'data': {} }"
On Tue, 20 Apr 2010 23:31:22 +0200 Juan Quintela <quintela@redhat.com> wrote: > Luiz Capitulino <lcapitulino@redhat.com> wrote: > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> > > VMState already used for two things in qemu, but I think that changing > to StateVM _only_ on the error messages is wrong. Leave it as vmstate, > and if rest of things get ever changed, change just everything? Let's use VMState then, I will fix.
diff --git a/qerror.c b/qerror.c index aa6892d..95c1a95 100644 --- a/qerror.c +++ b/qerror.c @@ -197,6 +197,10 @@ static const QErrorStringTable qerror_table[] = { .desc = "No block device can accept snapshots", }, { + .error_fmt = QERR_STATEVM_SAVE_FAILED, + .desc = "Failed to save VM state (%(reason))", + }, + { .error_fmt = QERR_TOO_MANY_FILES, .desc = "Too many open files", }, diff --git a/qerror.h b/qerror.h index 4a056b3..b915e26 100644 --- a/qerror.h +++ b/qerror.h @@ -163,6 +163,9 @@ QError *qobject_to_qerror(const QObject *obj); #define QERR_SNAPSHOT_NO_DEVICE \ "{ 'class': 'SnapshotNoDevice', 'data': {} }" +#define QERR_STATEVM_SAVE_FAILED \ + "{ 'class': 'StateVmSaveFailed', 'data': { 'reason': %s } }" + #define QERR_TOO_MANY_FILES \ "{ 'class': 'TooManyFiles', 'data': {} }"
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> --- qerror.c | 4 ++++ qerror.h | 3 +++ 2 files changed, 7 insertions(+), 0 deletions(-)