From patchwork Thu Apr 15 14:07:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miguel Di Ciurcio Filho X-Patchwork-Id: 50264 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 25E32B7C33 for ; Fri, 16 Apr 2010 01:10:22 +1000 (EST) Received: from localhost ([127.0.0.1]:57302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2Qhs-0000yn-Hy for incoming@patchwork.ozlabs.org; Thu, 15 Apr 2010 11:10:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2Ptk-0003gL-9v for qemu-devel@nongnu.org; Thu, 15 Apr 2010 10:18:28 -0400 Received: from [140.186.70.92] (port=50430 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2Pte-0003MB-Bs for qemu-devel@nongnu.org; Thu, 15 Apr 2010 10:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2PjD-0007kg-2k for qemu-devel@nongnu.org; Thu, 15 Apr 2010 10:07:36 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:40165) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2PjC-0007kT-Th for qemu-devel@nongnu.org; Thu, 15 Apr 2010 10:07:35 -0400 Received: by gwj21 with SMTP id 21so725040gwj.4 for ; Thu, 15 Apr 2010 07:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=Q6sphO5UTJdKVvqU3Pg31TCQkvfagy7mHRuwovxCTJ0=; b=fx1AjiPuKah8aga3i8t482+xpAnzYdO3dNiZe5F2NYCfoyHBjKSbpic4p3cjdf9g6b Hiz2oSLz+lAQjGZU4b/ErUcusbRfQ/4iw5yTVuQAuLyOTswhAOhVVPA2tbJ1Dq4eZpOt 2ROEzopLwaiZXA9X773hG9F96Spr5K6c6JO4A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=n8w9jI8t+yg7HRCvgA2hXPsJir7Ckd3GGijNxheU1QovCK4yjAL+/kJox2EZ7XCfyR 4VdNNkUAbMb8tSfdXtT/tUJOK/lg+jJAp3a3I1AeNXi96Hq8jpj0u7wky709UHhD0pmw SXlnHhEEbIVV3A/pX9mjoE8k7oE6mp6ldwe3Q= Received: by 10.101.153.5 with SMTP id f5mr297187ano.234.1271340450214; Thu, 15 Apr 2010 07:07:30 -0700 (PDT) Received: from localhost.localdomain (quake.ic.unicamp.br [143.106.7.51]) by mx.google.com with ESMTPS id y2sm1240378ani.4.2010.04.15.07.07.27 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 15 Apr 2010 07:07:29 -0700 (PDT) From: Miguel Di Ciurcio Filho To: qemu-devel@nongnu.org Date: Thu, 15 Apr 2010 11:07:06 -0300 Message-Id: <1271340427-12579-12-git-send-email-miguel.filho@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1271340427-12579-1-git-send-email-miguel.filho@gmail.com> References: <1271340427-12579-1-git-send-email-miguel.filho@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: armbru@redhat.com, lcapitulino@redhat.com Subject: [Qemu-devel] [PATCH v3 11/12] monitor/net: Convert do_info_network() to QObject/QMP X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Each device is represented by a QDict. The returned QObject is a QList of all devices. This commit slightly changes the monitor output when 'info network' is used. Old output: (qemu) info network VLAN 1 devices: e1000.0: model=e1000,macaddr=52:54:00:12:34:56 VLAN 0 devices: tap.0: ifname=tap0,script=/etc/kvm/kvm-ifup,downscript=/etc/qemu-ifdown Devices not on any VLAN: New output: (qemu) info network Devices on VLANs: e1000.0: vlan=1 model=e1000 macaddr=52:54:00:12:34:56 tap.0: vlan=0 script=/etc/kvm/kvm-ifup downscript=/etc/qemu-ifdown ifname=tap0 Devices not on any VLAN: Signed-off-by: Miguel Di Ciurcio Filho --- monitor.c | 3 +- net.c | 127 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---- net.h | 3 +- 3 files changed, 122 insertions(+), 11 deletions(-) diff --git a/monitor.c b/monitor.c index 4c6275e..34781ba 100644 --- a/monitor.c +++ b/monitor.c @@ -2610,7 +2610,8 @@ static const mon_cmd_t info_cmds[] = { .args_type = "", .params = "", .help = "show the network state", - .mhandler.info = do_info_network, + .user_print = do_info_network_print, + .mhandler.info_new = do_info_network, }, { .name = "chardev", diff --git a/net.c b/net.c index 8c02f28..46e8873 100644 --- a/net.c +++ b/net.c @@ -35,6 +35,8 @@ #include "sysemu.h" #include "qemu-common.h" #include "qemu_socket.h" +#include "qemu-objects.h" +#include "qobject.h" #include "qdict.h" #include "qstring.h" #include "hw/qdev.h" @@ -1285,28 +1287,135 @@ void net_set_boot_mask(int net_boot_mask) } } -void do_info_network(Monitor *mon) +static void vlan_devices_iter(QObject *obj, void *opaque) +{ + + Monitor *mon = opaque; + QDict *net_device = qobject_to_qdict(obj); + + if (!qdict_haskey(net_device, "vlan")) + return; + + monitor_printf(mon, " %s: vlan=%d ", qdict_get_str(net_device, "name"), + (int)qdict_get_int(net_device, "vlan")); + monitor_printf(mon, + qstring_get_str(qdict_to_qstring(qdict_get_qdict(net_device, "info")))); + + monitor_printf(mon, " \n"); +} + +static void non_vlan_devices_iter(QObject *obj, void *opaque) +{ + + Monitor *mon = opaque; + QDict *net_device = qobject_to_qdict(obj); + + if (qdict_haskey(net_device, "vlan")) + return; + + monitor_printf(mon, " %s: ", qdict_get_str(net_device, "name")); + + if (qdict_haskey(net_device, "peer")) + monitor_printf(mon, "peer=%s ", qdict_get_str(net_device, "peer")); + + monitor_printf(mon, + qstring_get_str(qdict_to_qstring(qdict_get_qdict(net_device, "info")))); + + monitor_printf(mon, "\n"); + +} + +void do_info_network_print(Monitor *mon, const QObject *ret_data) +{ + QList *qlist; + + qlist = qobject_to_qlist(ret_data); + + monitor_printf(mon, "Devices on VLANs:\n"); + + qlist_iter(qlist, vlan_devices_iter, mon); + + monitor_printf(mon, "Devices not on any VLAN:\n"); + + qlist_iter(qlist, non_vlan_devices_iter, mon); + +} + +/** + * do_network_info(): Network information + * + * Each network device information is stored in a QDict and the + * returned QObject is a QList of all devices. + * + * The QDict contains the following: + * + * - "name": device name + * - "vlan": only present if the device is attached to a VLAN, it is the id + * of the VLAN + * - "info": it is a QDict that may contain any of the following, depending on + * the type of the device: + * - "model": type of the device + * - "macaddr": MAC address + * - "script": path to script used to configure the device + * - "downscript": path to script used to deconfigure the device + * - "fd": handle to the device + * - "ifname": name of the host device connected to the guest device + * - "host": IP address of a socket + * - "service": port of a socket + * - "family": Internet protocol family (IPv4 or IPv6) + * + * Example: + * + * [ { "name": "tap.0", "vlan": 0, + "info": { "script": "/etc/kvm/kvm-ifup", "downscript": +"/etc/qemu-ifdown", + "ifname": "tap0" } }, + { "name": "e1000.0", "vlan": 1, + "info": { "model": "e1000", "macaddr": "52:54:00:12:34:56" } } ] + */ +void do_info_network(Monitor *mon, QObject **ret_data) { VLANState *vlan; VLANClientState *vc; + QDict *net_device; + QList *device_list; + device_list = qlist_new(); QTAILQ_FOREACH(vlan, &vlans, next) { - monitor_printf(mon, "VLAN %d devices:\n", vlan->id); + QObject *obj; QTAILQ_FOREACH(vc, &vlan->clients, next) { - monitor_printf(mon, " %s: %s\n", vc->name, vc->info_str); + + obj = qobject_from_jsonf("{ 'vlan': %d, 'name': %s }", vlan->id, +vc->name); + net_device = qobject_to_qdict(obj); + + QINCREF(vc->info_dict); + qdict_put(net_device, "info", vc->info_dict); + + qlist_append(device_list, qobject_to_qdict(obj)); + } } - monitor_printf(mon, "Devices not on any VLAN:\n"); + QTAILQ_FOREACH(vc, &non_vlan_clients, next) { - monitor_printf(mon, " %s: %s", vc->name, vc->info_str); - if (vc->peer) { - monitor_printf(mon, " peer=%s", vc->peer->name); - } - monitor_printf(mon, "\n"); + QObject *obj; + obj = qobject_from_jsonf("{ 'name': %s }", vc->name); + net_device = qobject_to_qdict(obj); + + QINCREF(vc->info_dict); + qdict_put(net_device, "info", vc->info_dict); + + if (vc->peer) + qdict_put(net_device, "peer", qstring_from_str(vc->peer->name)); + + qlist_append(device_list, net_device); } + + *ret_data = QOBJECT(device_list); } + int do_set_link(Monitor *mon, const QDict *qdict, QObject **ret_data) { VLANState *vlan; diff --git a/net.h b/net.h index d12276a..058420e 100644 --- a/net.h +++ b/net.h @@ -119,7 +119,8 @@ void qemu_check_nic_model(NICInfo *nd, const char *model); int qemu_find_nic_model(NICInfo *nd, const char * const *models, const char *default_model); -void do_info_network(Monitor *mon); +void do_info_network_print(Monitor *mon, const QObject *ret_data); +void do_info_network(Monitor *mon, QObject **ret_data); int do_set_link(Monitor *mon, const QDict *qdict, QObject **ret_data); /* NIC info */