diff mbox

[1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max

Message ID 1262849506-27132-2-git-send-email-amit.shah@redhat.com
State New
Headers show

Commit Message

Amit Shah Jan. 7, 2010, 7:31 a.m. UTC
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.

Also, bump up the value of the maximum allowed virtqueues to 64. This is
in preparation to allow multiple ports per virtio-console device.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
 hw/virtio.c |    2 --
 hw/virtio.h |    2 +-
 2 files changed, 1 insertions(+), 3 deletions(-)

Comments

Anthony Liguori Jan. 11, 2010, 7:57 p.m. UTC | #1
On 01/07/2010 01:31 AM, Amit Shah wrote:
> VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
> hw/virtio.h.
>
> Also, bump up the value of the maximum allowed virtqueues to 64. This is
> in preparation to allow multiple ports per virtio-console device.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>    

These will need rebasing against master.  It gets pretty ugly because of 
the rename.  Wait for me to do a review (today or tomorrow) before hand 
though.  I'll explicitly reply and Ack/Nack.

Regards,

Anthony Liguori
diff mbox

Patch

diff --git a/hw/virtio.c b/hw/virtio.c
index cecd0dc..88f4e78 100644
--- a/hw/virtio.c
+++ b/hw/virtio.c
@@ -75,8 +75,6 @@  struct VirtQueue
     void (*handle_output)(VirtIODevice *vdev, VirtQueue *vq);
 };
 
-#define VIRTIO_PCI_QUEUE_MAX        16
-
 /* virt queue functions */
 static void virtqueue_init(VirtQueue *vq)
 {
diff --git a/hw/virtio.h b/hw/virtio.h
index 35532a6..051910a 100644
--- a/hw/virtio.h
+++ b/hw/virtio.h
@@ -90,7 +90,7 @@  typedef struct {
     unsigned (*get_features)(void * opaque);
 } VirtIOBindings;
 
-#define VIRTIO_PCI_QUEUE_MAX 16
+#define VIRTIO_PCI_QUEUE_MAX 64
 
 #define VIRTIO_NO_VECTOR 0xffff