From patchwork Tue Dec 22 17:49:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 41635 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A213FB7BC7 for ; Wed, 23 Dec 2009 05:22:35 +1100 (EST) Received: from localhost ([127.0.0.1]:60543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NN9NJ-0003yo-TW for incoming@patchwork.ozlabs.org; Tue, 22 Dec 2009 13:22:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NN8sO-00027b-Er for qemu-devel@nongnu.org; Tue, 22 Dec 2009 12:50:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NN8sK-00025z-21 for qemu-devel@nongnu.org; Tue, 22 Dec 2009 12:50:27 -0500 Received: from [199.232.76.173] (port=35941 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NN8sJ-00025w-Mn for qemu-devel@nongnu.org; Tue, 22 Dec 2009 12:50:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13340) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NN8sI-0002iH-LT for qemu-devel@nongnu.org; Tue, 22 Dec 2009 12:50:23 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nBMHoKTL027932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Dec 2009 12:50:21 -0500 Received: from localhost (vpn-231-27.phx2.redhat.com [10.3.231.27]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nBMHoJsE003562; Tue, 22 Dec 2009 12:50:20 -0500 From: Amit Shah To: qemu-devel@nongnu.org Date: Tue, 22 Dec 2009 23:19:06 +0530 Message-Id: <1261504146-26018-4-git-send-email-amit.shah@redhat.com> In-Reply-To: <1261504146-26018-3-git-send-email-amit.shah@redhat.com> References: <1261504146-26018-1-git-send-email-amit.shah@redhat.com> <1261504146-26018-2-git-send-email-amit.shah@redhat.com> <1261504146-26018-3-git-send-email-amit.shah@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Amit Shah , armbru@redhat.com, agraf@suse.de, kraxel@redhat.com Subject: [Qemu-devel] [PATCH 3/3] virtio-serial: Add a new virtserialport device for generic serial port support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch adds generic serial ports over the virtio serial bus. These ports have a few more options that are not relevant for virtio console ports: the ability to cache buffers that are received for a port while it's disconnected, setting of limits to the bytes that are cached so as to prevent OOM conditions, etc. Sample uses for such a device can be obtaining info from the guest like the file systems used, apps installed, etc. for offline usage and logged-in users, clipboard copy-paste, etc. for online usage. For requirements, use-cases, test cases and some history see http://www.linux-kvm.org/page/VMchannel_Requirements Signed-off-by: Amit Shah --- hw/virtio-console.c | 37 +++++++++++++++++++++++++++++++++++++ 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index b2e4eb1..fc0c239 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -119,3 +119,40 @@ static void virtcon_register(void) virtio_serial_port_qdev_register(&virtcon_info); } device_init(virtcon_register) + + +/* Generic Virtio Serial Ports */ +static int virtserial_port_initfn(VirtIOSerialDevice *dev) +{ + VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, &dev->qdev); + VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port); + + port->info = dev->info; + + if (vcon->chr) { + qemu_chr_add_handlers(vcon->chr, chr_can_read, chr_read, chr_event, + vcon); + } + return 0; +} + +static VirtIOSerialPortInfo virtserial_port_info = { + .qdev.name = "virtserialport", + .qdev.size = sizeof(VirtConsole), + .init = virtserial_port_initfn, + .exit = vcon_exitfn, + .have_data = flush_buf, + .qdev.props = (Property[]) { + DEFINE_PROP_CHR("chardev", VirtConsole, chr), + DEFINE_PROP_STRING("name", VirtConsole, port.name), + DEFINE_PROP_INT32("cache_buffers", VirtConsole, port.cache_buffers, 1), + DEFINE_PROP_UINT64("byte_limit", VirtConsole, port.byte_limit, 0), + DEFINE_PROP_END_OF_LIST(), + }, +}; + +static void virtserial_port_register(void) +{ + virtio_serial_port_qdev_register(&virtserial_port_info); +} +device_init(virtserial_port_register)