From patchwork Sun Dec 20 01:39:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A . Shutemov" X-Patchwork-Id: 41501 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id F302DB6F18 for ; Sun, 20 Dec 2009 13:03:46 +1100 (EST) Received: from localhost ([127.0.0.1]:59516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMB8W-0001ny-3g for incoming@patchwork.ozlabs.org; Sat, 19 Dec 2009 21:03:08 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NMAmE-00089e-0h for qemu-devel@nongnu.org; Sat, 19 Dec 2009 20:40:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NMAm6-00083G-MM for qemu-devel@nongnu.org; Sat, 19 Dec 2009 20:40:03 -0500 Received: from [199.232.76.173] (port=54483 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NMAm5-00082P-55 for qemu-devel@nongnu.org; Sat, 19 Dec 2009 20:39:57 -0500 Received: from mail-fx0-f222.google.com ([209.85.220.222]:53674) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NMAm4-0004mU-RW for qemu-devel@nongnu.org; Sat, 19 Dec 2009 20:39:57 -0500 Received: by mail-fx0-f222.google.com with SMTP id 22so4042055fxm.2 for ; Sat, 19 Dec 2009 17:39:56 -0800 (PST) Received: by 10.223.95.88 with SMTP id c24mr2080253fan.39.1261273196475; Sat, 19 Dec 2009 17:39:56 -0800 (PST) Received: from localhost.localdomain (a88-114-220-92.elisa-laajakaista.fi [88.114.220.92]) by mx.google.com with ESMTPS id 13sm6982256fks.45.2009.12.19.17.39.54 (version=SSLv3 cipher=RC4-MD5); Sat, 19 Dec 2009 17:39:55 -0800 (PST) From: "Kirill A. Shutemov" To: qemu-devel@nongnu.org Date: Sun, 20 Dec 2009 03:39:24 +0200 Message-Id: <1261273167-3240-15-git-send-email-kirill@shutemov.name> X-Mailer: git-send-email 1.6.5.6 In-Reply-To: <1261273167-3240-14-git-send-email-kirill@shutemov.name> References: <1261273167-3240-1-git-send-email-kirill@shutemov.name> <1261273167-3240-2-git-send-email-kirill@shutemov.name> <1261273167-3240-3-git-send-email-kirill@shutemov.name> <1261273167-3240-4-git-send-email-kirill@shutemov.name> <1261273167-3240-5-git-send-email-kirill@shutemov.name> <1261273167-3240-6-git-send-email-kirill@shutemov.name> <1261273167-3240-7-git-send-email-kirill@shutemov.name> <1261273167-3240-8-git-send-email-kirill@shutemov.name> <1261273167-3240-9-git-send-email-kirill@shutemov.name> <1261273167-3240-10-git-send-email-kirill@shutemov.name> <1261273167-3240-11-git-send-email-kirill@shutemov.name> <1261273167-3240-12-git-send-email-kirill@shutemov.name> <1261273167-3240-13-git-send-email-kirill@shutemov.name> <1261273167-3240-14-git-send-email-kirill@shutemov.name> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: "Kirill A. Shutemov" Subject: [Qemu-devel] [PATCH 15/18] monitor.c: fix warnings with _FORTIFY_SOURCE X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org CC i386-softmmu/monitor.o cc1: warnings being treated as errors /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c: In function 'do_memory_save': /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c:1318: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c: In function 'do_physical_memory_save': /usr/src/RPM/BUILD/qemu-0.11.92/monitor.c:1345: error: ignoring return value of 'fwrite', declared with attribute warn_unused_result make[1]: *** [monitor.o] Error 1 Signed-off-by: Kirill A. Shutemov --- monitor.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index c0dc48e..54c7323 100644 --- a/monitor.c +++ b/monitor.c @@ -1320,10 +1320,14 @@ static void do_memory_save(Monitor *mon, const QDict *qdict, QObject **ret_data) if (l > size) l = size; cpu_memory_rw_debug(env, addr, buf, l, 0); - fwrite(buf, 1, l, f); + if (fwrite(buf, 1, l, f) != l) { + monitor_printf(mon, "fwrite() failed\n"); + goto exit; + } addr += l; size -= l; } +exit: fclose(f); } @@ -1347,11 +1351,15 @@ static void do_physical_memory_save(Monitor *mon, const QDict *qdict, if (l > size) l = size; cpu_physical_memory_rw(addr, buf, l, 0); - fwrite(buf, 1, l, f); + if (fwrite(buf, 1, l, f) != l) { + monitor_printf(mon, "fwrite() failed\n"); + goto exit; + } fflush(f); addr += l; size -= l; } +exit: fclose(f); }