From patchwork Thu Sep 10 08:58:36 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 33273 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id B07DAB707B for ; Thu, 10 Sep 2009 19:01:06 +1000 (EST) Received: from localhost ([127.0.0.1]:36412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlfWO-00065x-WC for incoming@patchwork.ozlabs.org; Thu, 10 Sep 2009 05:00:53 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlfUk-0005QD-Le for qemu-devel@nongnu.org; Thu, 10 Sep 2009 04:59:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlfUf-0005O7-Mr for qemu-devel@nongnu.org; Thu, 10 Sep 2009 04:59:09 -0400 Received: from [199.232.76.173] (port=49315 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlfUe-0005Na-PF for qemu-devel@nongnu.org; Thu, 10 Sep 2009 04:59:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16427) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MlfUe-0007VH-1N for qemu-devel@nongnu.org; Thu, 10 Sep 2009 04:59:04 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8A8x23d025526 for ; Thu, 10 Sep 2009 04:59:03 -0400 Received: from zweiblum.home.kraxel.org (vpn2-9-74.ams2.redhat.com [10.36.9.74]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with SMTP id n8A8wwUY017241; Thu, 10 Sep 2009 04:58:59 -0400 Received: by zweiblum.home.kraxel.org (Postfix, from userid 500) id 7F419700E1; Thu, 10 Sep 2009 10:58:56 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 10 Sep 2009 10:58:36 +0200 Message-Id: <1252573135-27688-5-git-send-email-kraxel@redhat.com> In-Reply-To: <1252573135-27688-1-git-send-email-kraxel@redhat.com> References: <1252573135-27688-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Gerd Hoffmann Subject: [Qemu-devel] [PATCH v2 04/23] convert file+pipe chardevs to QemuOpts. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org new cmd line syntax: -chardev file,id=name,path=/path/to/file -chardev pipe,id=name,path=/path/to/pipe Signed-off-by: Gerd Hoffmann --- qemu-char.c | 47 ++++++++++++++++++++++++++++++++--------------- qemu-config.c | 7 +++++++ 2 files changed, 39 insertions(+), 15 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index bd2eca8..0573033 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -626,20 +626,27 @@ static CharDriverState *qemu_chr_open_fd(int fd_in, int fd_out) return chr; } -static CharDriverState *qemu_chr_open_file_out(const char *file_out) +static CharDriverState *qemu_chr_open_file_out(QemuOpts *opts) { int fd_out; - TFR(fd_out = open(file_out, O_WRONLY | O_TRUNC | O_CREAT | O_BINARY, 0666)); + TFR(fd_out = open(qemu_opt_get(opts, "path"), + O_WRONLY | O_TRUNC | O_CREAT | O_BINARY, 0666)); if (fd_out < 0) return NULL; return qemu_chr_open_fd(-1, fd_out); } -static CharDriverState *qemu_chr_open_pipe(const char *filename) +static CharDriverState *qemu_chr_open_pipe(QemuOpts *opts) { int fd_in, fd_out; char filename_in[256], filename_out[256]; + const char *filename = qemu_opt_get(opts, "path"); + + if (filename == NULL) { + fprintf(stderr, "chardev: pipe: no filename given\n"); + return NULL; + } snprintf(filename_in, 256, "%s.in", filename); snprintf(filename_out, 256, "%s.out", filename); @@ -1658,8 +1665,9 @@ static int win_chr_pipe_init(CharDriverState *chr, const char *filename) } -static CharDriverState *qemu_chr_open_win_pipe(const char *filename) +static CharDriverState *qemu_chr_open_win_pipe(QemuOpts *opts) { + const char *filename = qemu_opt_get(opts, "path"); CharDriverState *chr; WinCharState *s; @@ -1697,8 +1705,9 @@ static CharDriverState *qemu_chr_open_win_con(const char *filename) return qemu_chr_open_win_file(GetStdHandle(STD_OUTPUT_HANDLE)); } -static CharDriverState *qemu_chr_open_win_file_out(const char *file_out) +static CharDriverState *qemu_chr_open_win_file_out(QemuOpts *opts) { + const char *file_out = qemu_opt_get(opts, "path"); HANDLE fd_out; fd_out = CreateFile(file_out, GENERIC_WRITE, FILE_SHARE_READ, NULL, @@ -2218,6 +2227,7 @@ static CharDriverState *qemu_chr_open_tcp(const char *host_str, static QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename) { + const char *p; QemuOpts *opts; opts = qemu_opts_create(&qemu_chardev_opts, label, 1); @@ -2228,6 +2238,16 @@ static QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename) qemu_opt_set(opts, "backend", "null"); return opts; } + if (strstart(filename, "file:", &p)) { + qemu_opt_set(opts, "backend", "file"); + qemu_opt_set(opts, "path", p); + return opts; + } + if (strstart(filename, "pipe:", &p)) { + qemu_opt_set(opts, "backend", "pipe"); + qemu_opt_set(opts, "path", p); + return opts; + } qemu_opts_del(opts); return NULL; @@ -2238,6 +2258,13 @@ static const struct { CharDriverState *(*open)(QemuOpts *opts); } backend_table[] = { { .name = "null", .open = qemu_chr_open_null }, +#ifdef _WIN32 + { .name = "file", .open = qemu_chr_open_win_file_out }, + { .name = "pipe", .open = qemu_chr_open_win_pipe }, +#else + { .name = "file", .open = qemu_chr_open_file_out }, + { .name = "pipe", .open = qemu_chr_open_pipe }, +#endif }; CharDriverState *qemu_chr_open_opts(QemuOpts *opts, @@ -2316,10 +2343,6 @@ CharDriverState *qemu_chr_open(const char *label, const char *filename, void (*i #ifndef _WIN32 if (strstart(filename, "unix:", &p)) { chr = qemu_chr_open_tcp(p, 0, 1); - } else if (strstart(filename, "file:", &p)) { - chr = qemu_chr_open_file_out(p); - } else if (strstart(filename, "pipe:", &p)) { - chr = qemu_chr_open_pipe(p); } else if (!strcmp(filename, "pty")) { chr = qemu_chr_open_pty(); } else if (!strcmp(filename, "stdio")) { @@ -2344,15 +2367,9 @@ CharDriverState *qemu_chr_open(const char *label, const char *filename, void (*i if (strstart(filename, "COM", NULL)) { chr = qemu_chr_open_win(filename); } else - if (strstart(filename, "pipe:", &p)) { - chr = qemu_chr_open_win_pipe(p); - } else if (strstart(filename, "con:", NULL)) { chr = qemu_chr_open_win_con(filename); } else - if (strstart(filename, "file:", &p)) { - chr = qemu_chr_open_win_file_out(p); - } else #endif #ifdef CONFIG_BRLAPI if (!strcmp(filename, "braille")) { diff --git a/qemu-config.c b/qemu-config.c index b156c24..49be6be 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -79,6 +79,13 @@ QemuOptsList qemu_chardev_opts = { .name = "chardev", .head = TAILQ_HEAD_INITIALIZER(qemu_chardev_opts.head), .desc = { + { + .name = "backend", + .type = QEMU_OPT_STRING, + },{ + .name = "path", + .type = QEMU_OPT_STRING, + }, { /* end if list */ } }, };