From patchwork Fri Aug 28 18:27:30 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 32432 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id B331DB7257 for ; Sat, 29 Aug 2009 05:25:31 +1000 (EST) Received: from localhost ([127.0.0.1]:36002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh74b-0007tH-W8 for incoming@patchwork.ozlabs.org; Fri, 28 Aug 2009 15:25:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mh6CA-00082L-Ut for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:29:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mh6C6-0007yy-2x for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:29:06 -0400 Received: from [199.232.76.173] (port=41324 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh6C5-0007yf-SD for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:29:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11207) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mh6C5-0003DJ-DI for qemu-devel@nongnu.org; Fri, 28 Aug 2009 14:29:01 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7SIT0ZR022788; Fri, 28 Aug 2009 14:29:00 -0400 Received: from localhost (vpn-10-114.bos.redhat.com [10.16.10.114]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7SISxC8001697; Fri, 28 Aug 2009 14:28:59 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Fri, 28 Aug 2009 15:27:30 -0300 Message-Id: <1251484052-3939-28-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com> References: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com, avi@redhat.com Subject: [Qemu-devel] [PATCH 27/29] Introduce QString unit-tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This suite contains tests to assure that QString API works as expected. To execute it you should have check installed and build QEMU with check support enabled (--enable-check-utests) and then run: $ ./check-qstring Signed-off-by: Luiz Capitulino --- Makefile | 1 + check-qstring.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ configure | 2 +- 3 files changed, 102 insertions(+), 1 deletions(-) create mode 100644 check-qstring.c diff --git a/Makefile b/Makefile index d08df6c..6537f77 100644 --- a/Makefile +++ b/Makefile @@ -182,6 +182,7 @@ qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx $(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@," GEN $@") check-qint: check-qint.o qint.o qemu-malloc.o +check-qstring: check-qstring.o qstring.o qemu-malloc.o clean: # avoid old build problems by removing potentially incorrect old files diff --git a/check-qstring.c b/check-qstring.c new file mode 100644 index 0000000..ea4dfd0 --- /dev/null +++ b/check-qstring.c @@ -0,0 +1,100 @@ +/* + * QString unit-tests. + * + * Copyright (C) 2009 Red Hat Inc. + * + * Authors: + * Luiz Capitulino + */ +#include + +#include "qstring.h" +#include "qemu-common.h" + +/* + * Public Interface test-cases + * + * (with some violations to access 'private' data) + */ + +START_TEST(qstring_from_str_test) +{ + QString *qstring; + const char *str = "QEMU"; + + qstring = qstring_from_str(str); + fail_unless(qstring != NULL); + fail_unless(qstring->base.refcnt == 1); + fail_unless(strcmp(str, qstring->string) == 0); + fail_unless(qobject_type(QOBJECT(qstring)) == QTYPE_QSTRING); + + // destroy doesn't exit yet + qemu_free(qstring->string); + qemu_free(qstring); +} +END_TEST + +START_TEST(qstring_destroy_test) +{ + QString *qstring = qstring_from_str("destroy test"); + QDECREF(qstring); +} +END_TEST + +START_TEST(qstring_get_str_test) +{ + QString *qstring; + const char *ret_str; + const char *str = "QEMU/KVM"; + + qstring = qstring_from_str(str); + ret_str = qstring_get_str(qstring); + fail_unless(strcmp(ret_str, str) == 0); + + QDECREF(qstring); +} +END_TEST + +START_TEST(qobject_to_qstring_test) +{ + QString *qstring; + + qstring = qstring_from_str("foo"); + fail_unless(qobject_to_qstring(QOBJECT(qstring)) == qstring); + + QDECREF(qstring); +} +END_TEST + +static Suite *qstring_suite(void) +{ + Suite *s; + TCase *qstring_public_tcase; + + s = suite_create("QString test-suite"); + + qstring_public_tcase = tcase_create("Public Interface"); + suite_add_tcase(s, qstring_public_tcase); + tcase_add_test(qstring_public_tcase, qstring_from_str_test); + tcase_add_test(qstring_public_tcase, qstring_destroy_test); + tcase_add_test(qstring_public_tcase, qstring_get_str_test); + tcase_add_test(qstring_public_tcase, qobject_to_qstring_test); + + return s; +} + +int main(void) +{ + int nf; + Suite *s; + SRunner *sr; + + s = qstring_suite(); + sr = srunner_create(s); + + srunner_run_all(sr, CK_NORMAL); + nf = srunner_ntests_failed(sr); + srunner_free(sr); + + return (nf == 0) ? EXIT_SUCCESS : EXIT_FAILURE; +} diff --git a/configure b/configure index 248cc0b..c2944c5 100755 --- a/configure +++ b/configure @@ -1927,7 +1927,7 @@ if test `expr "$target_list" : ".*softmmu.*"` != 0 ; then if [ "$linux" = "yes" ] ; then tools="qemu-nbd\$(EXESUF) qemu-io\$(EXESUF) $tools" if [ "$check_utests" = "yes" ]; then - tools="check-qint $tools" + tools="check-qint check-qstring $tools" fi fi fi