From patchwork Wed Aug 26 13:05:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Glauber Costa X-Patchwork-Id: 32170 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id D42C3B7087 for ; Thu, 27 Aug 2009 03:34:40 +1000 (EST) Received: from localhost ([127.0.0.1]:56561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgMOH-0007ma-6l for incoming@patchwork.ozlabs.org; Wed, 26 Aug 2009 13:34:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MgLwo-0002bp-I2 for qemu-devel@nongnu.org; Wed, 26 Aug 2009 13:06:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MgLwj-0002Ty-D3 for qemu-devel@nongnu.org; Wed, 26 Aug 2009 13:06:09 -0400 Received: from [199.232.76.173] (port=45790 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MgLwj-0002TO-1Y for qemu-devel@nongnu.org; Wed, 26 Aug 2009 13:06:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26416) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MgLwi-0000an-5m for qemu-devel@nongnu.org; Wed, 26 Aug 2009 13:06:04 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7QH5tbZ031789; Wed, 26 Aug 2009 13:05:55 -0400 Received: from localhost.localdomain (virtlab1.virt.bos.redhat.com [10.16.72.21]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7QH5kJt009197; Wed, 26 Aug 2009 13:05:54 -0400 From: Glauber Costa To: qemu-devel@nongnu.org Date: Wed, 26 Aug 2009 09:05:44 -0400 Message-Id: <1251291946-25821-11-git-send-email-glommer@redhat.com> In-Reply-To: <1251291946-25821-10-git-send-email-glommer@redhat.com> References: <1251291946-25821-1-git-send-email-glommer@redhat.com> <1251291946-25821-2-git-send-email-glommer@redhat.com> <1251291946-25821-3-git-send-email-glommer@redhat.com> <1251291946-25821-4-git-send-email-glommer@redhat.com> <1251291946-25821-5-git-send-email-glommer@redhat.com> <1251291946-25821-6-git-send-email-glommer@redhat.com> <1251291946-25821-7-git-send-email-glommer@redhat.com> <1251291946-25821-8-git-send-email-glommer@redhat.com> <1251291946-25821-9-git-send-email-glommer@redhat.com> <1251291946-25821-10-git-send-email-glommer@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: aliguori@us.ibm.com, Torsten Duwe , Christoph Hellwig Subject: [Qemu-devel] [PATCH 10/12] BACKPORT: Fix segfault of qemu-system-arm with PXA target X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Torsten Duwe qemu-system-arm (0.10.5) segfaults when invoked with a PXA machine target, e.g. -M tosa. The reason is fairly obvious: [backport: current code uses struct scoop_info_s instead of a typedef ] Signed-off-by: Torsten Duwe Signed-off-by: Christoph Hellwig Signed-off-by: Andrzej Zaborowski Signed-off-by: Glauber Costa --- hw/zaurus.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/zaurus.c b/hw/zaurus.c index 8b16c47..7c1fd2a 100644 --- a/hw/zaurus.c +++ b/hw/zaurus.c @@ -160,7 +160,7 @@ static CPUWriteMemoryFunc *scoop_writefn[] = { void scoop_gpio_set(void *opaque, int line, int level) { - struct scoop_info_s *s = (struct scoop_info_s *) s; + struct scoop_info_s *s = (struct scoop_info_s *) opaque; if (level) s->gpio_level |= (1 << line);