From patchwork Mon Aug 3 16:56:59 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 30655 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id A5989B6F20 for ; Tue, 4 Aug 2009 05:24:16 +1000 (EST) Received: from localhost ([127.0.0.1]:58522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MY38m-0007bz-Sw for incoming@patchwork.ozlabs.org; Mon, 03 Aug 2009 15:24:12 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MY0rd-0005yF-QG for qemu-devel@nongnu.org; Mon, 03 Aug 2009 12:58:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MY0rZ-0005vy-Ol for qemu-devel@nongnu.org; Mon, 03 Aug 2009 12:58:21 -0400 Received: from [199.232.76.173] (port=55271 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MY0rZ-0005vq-HQ for qemu-devel@nongnu.org; Mon, 03 Aug 2009 12:58:17 -0400 Received: from mx2.redhat.com ([66.187.237.31]:56279) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MY0rZ-00038A-1u for qemu-devel@nongnu.org; Mon, 03 Aug 2009 12:58:17 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n73GwGNW026224; Mon, 3 Aug 2009 12:58:16 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n73GwFHD015298; Mon, 3 Aug 2009 12:58:15 -0400 Received: from localhost (vpn-10-1.bos.redhat.com [10.16.10.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n73GwDqV030063; Mon, 3 Aug 2009 12:58:14 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Mon, 3 Aug 2009 13:56:59 -0300 Message-Id: <1249318642-19324-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1249318642-19324-1-git-send-email-lcapitulino@redhat.com> References: <1249318642-19324-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, avi@redhat.com Subject: [Qemu-devel] [PATCH 02/25] net: Fix do_set_link() return type X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org do_set_link() returns int, but Monitor handler functions should always return void. Signed-off-by: Luiz Capitulino --- net.c | 6 ++---- net.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/net.c b/net.c index b5e8c9f..1b531e7 100644 --- a/net.c +++ b/net.c @@ -2905,7 +2905,7 @@ void do_info_network(Monitor *mon) } } -int do_set_link(Monitor *mon, const char *name, const char *up_or_down) +void do_set_link(Monitor *mon, const char *name, const char *up_or_down) { VLANState *vlan; VLANClientState *vc = NULL; @@ -2918,7 +2918,7 @@ done: if (!vc) { monitor_printf(mon, "could not find network device '%s'", name); - return 0; + return; } if (strcmp(up_or_down, "up") == 0) @@ -2931,8 +2931,6 @@ done: if (vc->link_status_changed) vc->link_status_changed(vc); - - return 1; } void net_cleanup(void) diff --git a/net.h b/net.h index 188fa39..3ac9e8c 100644 --- a/net.h +++ b/net.h @@ -79,7 +79,7 @@ void qemu_check_nic_model_list(NICInfo *nd, const char * const *models, void qemu_handler_true(void *opaque); void do_info_network(Monitor *mon); -int do_set_link(Monitor *mon, const char *name, const char *up_or_down); +void do_set_link(Monitor *mon, const char *name, const char *up_or_down); void do_info_usernet(Monitor *mon);