From patchwork Tue Oct 9 03:30:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Baron X-Patchwork-Id: 190195 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1A6C32C00BD for ; Tue, 9 Oct 2012 15:38:36 +1100 (EST) Received: from localhost ([::1]:52235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLQXy-00035n-3w for incoming@patchwork.ozlabs.org; Mon, 08 Oct 2012 23:31:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLQWr-0001GI-TL for qemu-devel@nongnu.org; Mon, 08 Oct 2012 23:30:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLQWq-0001tK-8f for qemu-devel@nongnu.org; Mon, 08 Oct 2012 23:30:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLQWp-0001tD-MR for qemu-devel@nongnu.org; Mon, 08 Oct 2012 23:30:44 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q993UawE025923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 8 Oct 2012 23:30:40 -0400 Received: from redhat.com (dhcp-185-114.bos.redhat.com [10.16.185.114]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q993UaqX023059; Mon, 8 Oct 2012 23:30:36 -0400 Date: Mon, 8 Oct 2012 23:30:36 -0400 From: Jason Baron To: qemu-devel@nongnu.org Message-Id: <092c0acd50dc7d66ec0d46277e2fec207c41ffdf.1349749915.git.jbaron@redhat.com> In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, armbru@redhat.com, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, kraxel@redhat.com Subject: [Qemu-devel] [PATCH v2 16/21] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka Both bits are added to the write-1-to-clear mask by default. As the smbus device does not allow writes at all, we have to remove it from that mask, also to avoid triggering a runtime assertion. Signed-off-by: Jan Kiszka Signed-off-by: Jason Baron Reviewed-by: Paolo Bonzini --- hw/q35_smbus.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/q35_smbus.c b/hw/q35_smbus.c index 5efbe6c..dd64aa2 100644 --- a/hw/q35_smbus.c +++ b/hw/q35_smbus.c @@ -97,6 +97,10 @@ static int ich9_smbus_initfn(PCIDevice *d) pci_set_word(d->wmask + PCI_STATUS, PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY); + pci_set_word(d->w1cmask + PCI_STATUS, + pci_get_word(d->w1cmask + PCI_STATUS) & + ~(PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY)); + /* TODO? D31IP.SMIP in chipset configuration space */ pci_config_set_interrupt_pin(d->config, 0x01); /* interrupt pin 1 */