From patchwork Wed Dec 6 22:22:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 845376 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="EM7dqlWp"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ysYFQ4Ynjz9s71 for ; Thu, 7 Dec 2017 09:29:30 +1100 (AEDT) Received: from localhost ([::1]:58070 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMiC0-0001zU-Nz for incoming@patchwork.ozlabs.org; Wed, 06 Dec 2017 17:29:28 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMi9u-0000Ue-9M for qemu-devel@nongnu.org; Wed, 06 Dec 2017 17:27:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMi9q-0002OT-Uz for qemu-devel@nongnu.org; Wed, 06 Dec 2017 17:27:18 -0500 Received: from mail-bl2nam02on0071.outbound.protection.outlook.com ([104.47.38.71]:50336 helo=NAM02-BL2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMi9q-0002O9-OJ for qemu-devel@nongnu.org; Wed, 06 Dec 2017 17:27:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TNodxcH1bLKzGX4d/cMO677I635ZyGCo62rUv1jqK/Q=; b=EM7dqlWpFLEE3DiFzbV7RdOezXxRY6JXAmksJUMm5BQ7/VoZsPY8pVVdydvkf+/GmWhsISYZ/IO2b6ZaAUPXpBDBerXfbl22AmvHFcujfVD/HdjzkAfgB0mCt3DQyRvisdA8Je9977syDcO1rdsVUVxPQUJkVRHQQGdEgiLLnus= Received: from SN4PR0201CA0062.namprd02.prod.outlook.com (10.171.31.152) by MWHPR02MB3389.namprd02.prod.outlook.com (10.164.187.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 6 Dec 2017 22:27:10 +0000 Received: from SN1NAM02FT049.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::200) by SN4PR0201CA0062.outlook.office365.com (2603:10b6:803:20::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Wed, 6 Dec 2017 22:27:10 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; adacore.com; dkim=none (message not signed) header.d=none;adacore.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT049.mail.protection.outlook.com (10.152.72.166) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5 via Frontend Transport; Wed, 6 Dec 2017 22:27:07 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:57707 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1eMi9i-0006Qz-Rn; Wed, 06 Dec 2017 14:27:06 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eMi9i-0000o5-Kh; Wed, 06 Dec 2017 14:27:06 -0800 Received: from xsj-pvapsmtp01 (smtp.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vB6MQwlm012970; Wed, 6 Dec 2017 14:26:58 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eMi9a-0000kQ-I0; Wed, 06 Dec 2017 14:26:58 -0800 From: Alistair Francis To: , , Date: Wed, 6 Dec 2017 14:22:50 -0800 Message-ID: <08c0ac2d39768dcabb83ebe186cafdf18360151a.1512598866.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23512.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(346002)(2980300002)(438002)(189003)(199004)(9786002)(16586007)(51416003)(7696005)(76176011)(2906002)(106466001)(36756003)(33646002)(50226002)(63266004)(478600001)(81166006)(77096006)(8676002)(81156014)(48376002)(6666003)(356003)(54906003)(8936002)(4326008)(305945005)(118296001)(2950100002)(47776003)(316002)(110136005)(36386004)(39060400002)(50466002)(106002)(2201001)(5660300001)(107986001)(5001870100001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR02MB3389; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT049; 1:23Qb8alupzsRmRu6NC/YUtuH+5GKbcl1zwitADFvtBldsKTZD/azwZ8zcPjGwxQT70Z1KhYGmvX75zKx8hi+EzWxTPvFxTaRbQg69clIz9sB8kf8AqtiXt2IFpjQF7e9 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9236d58c-8d28-447b-1965-08d53cf87d54 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4608076)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286); SRVR:MWHPR02MB3389; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3389; 3:VTzNehxWbOYovT/2M63gN9EdMcZUGMkKMVGuN2eK8R+uHOCMzQrU828C1103qGmdNFNFD4rGNjsN9lVayJcO27b5BVnHcvO5QGoITdDhegbDO5+obqU4iN2S73r6hA2GlP9KxP4JyaRCEqPDGWfSz4s0DcWS0GWhMiQTUCt7aaNjStxUrpXq016MdzHIKh0eAySJkjfaKAJCnt+sAKkN2dFhAt4Pq58ps0GyjXr/rg+l3csDz/FRjHODF3Xq12GR2o6XbysHt2HGg/JpbZCn8k4eiiZVaJnzq5FM4MB5qkw00ru7LMAWeDsqri+gKDDQzaA8hUJjRUkOFVSUb2g68xJZXY0DDCBZbRoxOkmgX7g=; 25:OcU8P5M80WD0bmhcC/NzkIBObnh66l0AP9kTIe7nswQYedQPVyilEmjymksH9kci0mpIWzLq80EBY+J00Sk1K0kA89H/7OJ37mboOjmNTzLx907aeglbLHaoYh7oOA4byyyr7yU3g6NrGfU2OfQIsHozQ2/0P+YiebXO8iPaFcG7dyHhdirrOO299jw1mpx3e9+MrCXt8qpifD2uqZhQFXPqjSKbqaoCrVYUIBgr8hcR3QjMfujINsHtXSl6NIJ0qkcHncr0uI8LCGxwcN3cUym4M1MryB0rzelDaIfKekQWdTJ2NX7Qmm9coI1I81aK1Vl1Q/ujXxNSGorb/aR/4g== X-MS-TrafficTypeDiagnostic: MWHPR02MB3389: X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3389; 31:BvkcjMgZ8qdJG4hkNpRGNgeCm6KbgsIt1F/K49nFhfHRlygoTi8FA9ImYinzU1DD4efWbUYk3iUFf/5R+yMFYimRqpxtc2JQflr9ER5LquDTmH1njbzHLk0Y9G/xrJUi2xau+eptWFZYlhpyYh/4Q1H5t7teVdwXt7nLkLadzDjed9n/O0fsnTiv57O0uqBdYNusPkcpar8Z3m9YShJ8XhmZ6DT+9H9yB9TglhPi9X0=; 20:QMECodXpsKmEGYX1Z4x7MUNu+m4pFmf4Mt17HcRn0jMt3VN5jvOIL7KE2/+8JrH4raaxhZ1lXk3VcV9sYHSj4+JaKk5qbtwn/LlajYxhWAspq/n1VJKRV+aP2Kz/wkqEfhOQbJoHdKOvbkk1BX9/ceoUI7cJpEjq9+Yc5HEAbK9DHQrP4UbkBjBBkJTo4G/jfF/zaCZa9g2vy3ErmY5bQo5OzEZCxe+Ey7o9jI145XlLp4gXVtHtj7jcMrJrCoiPjHU4SSzXkcH7Z7MNyAaGXRAlB7cLlkRD0Z8s2ve4/z/jVGGhgAnNhi9AjYRR+2UeDuJjGoAmIQK/HuFJHcBrsrN3KoUZiNjxkPwMORkEnpDeqg4B0302Mk4fU5Nj5Q4hMHVpCo4AQ+r6Ox96dsquacbvi6HkJHuUiSpiL0uirNCwQE07IgyrG3BBWl6QMyDROpDhCmXDVubM7HJm1UyT6AKTrFycWuwM0fRXfi+O+QDrSc6suPcbxbcBDk2+bIm8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(3231022)(10201501046)(93006095)(93004095)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(6072148)(201708071742011); SRVR:MWHPR02MB3389; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR02MB3389; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3389; 4:Yz4xRmPnkuQxDSJUc9jnqNjYXheZKM4HD/09YIbvIm+YMagEjHdPrJ2xLxcI0yIgobDJJnBvdjShhzUH1evczI02ilxu6ghP7+rvdckxkDbQuEXKBVAvU/r0LptnDViVgenOjIl/C4CsaKQIrcJt6PWKHtXQhA1eVRB35iqnmJg7tx6v9YuH8bsXwQQu7chd68m37JqIUvxX+Qly2uDEzcq+yXy0DO8NtVrBVna2X2sD2uHGP0iuYVDRYCV35Yz4S2EdWkhrDg2/8qlkY3pm9VhJ7SW/CxWyohPeApNKUvH3NdWXZSRTog5pPe/fRIKN X-Forefront-PRVS: 05134F8B4F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR02MB3389; 23:QYjH9/2BXjjDenj8Ip62FWF2SUSFj1os8VAqFBObQ?= OHWmetrzfCwyp2hefuTpegLapWMdb/7x6EgkjZpUqAupX3dJbiivn9yPRSVs/XQ/iSkfTHSu46vJ2wz1rvev9FWLM+fq9fS0F3wi5AL5AQIQ2y1h5YVTCV+35Th9RCiWFQCmV5P8bDcejN1wgc1keWRWnv8kz02k7fxzV4/tFnIofMkS/DnOq9W+h6WxShsg0Ep1FFA74Lsa1i9AynkOyK1KgnfNYB1ugPQs2aqiwE1yw734DVTzZy0qeF3ggH1jX2ovSEqlJ359g0OzbA+JVKPsQN51PJaqgodqGQ50pdWpJdrZj1aFO7lmQUmNxCA7DHzKAh6tNHqnXKMykXw9MP8gVfYqkDt54Co5exFSaFfK4l2H8KdjPxTqNNBFwZ7OtxZrjf9shIwNQxZEMWu5hrSSAl2GZE9vKqTeYmepdcQXTOHzFzMLQ1yMH6ZAe7nxcpVT3pJCRanriCHQrw4ChbLva+Hc8XoCrVui9XsW3OCyH/8ZPSo6JiqIE/wx39FXzMOhqvz9EtSJH6p5xQKiezDFyXKqT/TvmvfVEN4x5tNgOpyCXCf7Y3mXBlbD25DFWVwsRvKy9+jnerMYLRlIYuqF8RZHBeRKk31xX9nGQuM2vyHstz7yA/EK94bE5uLoQ04HKFP4EnQcZ+eLr7EOV2KCSieA79PXA+Hh8g9SiU35rWaAkbLEn6ZWDDO8Id84MQCd1JO1jkZnLB0MaesrX+aQ4aP/ebmjh/VqIUuRHGLrtf+cMN0DqD4AtkuOt62DTzgs8Voj7rldRz3hXnj9cXeKqcoNWJa46v/30LRZ74Rd0miLs0tz1aUjSjD8Pb7Uj3T/6xEZNhlbWZZmNCgnlsZVl/+hc1H3EbTMzpxOXTTeirGi0j38HQrV7KsjnBhnvNFAYrQ/DvivIUVuBQNAhzOUfkpY50ggdXtUxWeTw6b8js6+zvwRIPqJQ/LU98nLTr9+JezAluVBarGJzgW+jJdIt/FHXGL2ISGYpgDK+mXKA== X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3389; 6:B0IBkPDrwJFdU+CzRUAedSSl+Rvr4Lv9umhUYd2uwn5uYRXqeT70Yvup9s3jAnh7FAtB4TxswfVuXCbYh+28Zy/IEYoyQ67riY0iRg62y6AhmMInQBXWAM5YHDraba0KutaiuP7nvr+mPFjOLLt6s1jKz2azziY3EtXwyQs+INHOgc2YGeDl+PddwHnoutDFOF4hkO4bAJZpxPzStVmsyddfCxmKqeDIYqFfirewG0eU4BYzMecvDOj+FDWebYtC1WiZXssLaCdpZtgMiG9r92Kc72JYWNKUkz05iicFmrH4OT0Q3DOUyAj2DTi/6DDu/nGtxbZbtEc4mEzylp1eIi0jbkcBc3KphxS26PXrSy4=; 5:DzLBe/vqMEab1uM83uDhAVlGGnn1r50tU5zNomYhZW/xd1/PRWan+l4T79ph+pOhOsT5ac18XXSJtZPz7KAHkJmDjmf/HutYiVTu+fJkban9EQ4stgvgNvUDeeWMkYgaoQqSJXaeyM8HJVKfuUBhtGsHsFezrjh+IZphQCXGX8s=; 24:AB+CiD95scC5bJFfgOHsx7Erbz8w3M19sLXkL+5m3jqoabY+IuffQzQoY8/mk1zSj7mgCGDGJ4fFyax4ZQkeD4qVBkc5O1byHjMlKXzkjJk=; 7:8LxHxa0v2q06zklEwKQmy6M8bPRjV8JegIKYGzcve4wsWJDzQkImHAS2Y70iZ20dIm4eGF66x6E7ElRazLaIcBKUhGeXrgI21s6/6/5fALt7ROpLQGRryNMVI3VnZHaGQlCLw0aSxo5Hcj7HSadx2qcx2IPPCus5qKhaTLS7NyBPK+1Jz0Ubk9bX6VF8rHm0sxhRsb8pLPyYo8HOC2wDnIyQsqc9HEURFjT2bYK83wqGjts0jKjkJtaJZs+Y1ZLX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2017 22:27:07.6262 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9236d58c-8d28-447b-1965-08d53cf87d54 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3389 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.38.71 Subject: [Qemu-devel] [PATCH-2.12 v2 3/3] xilinx_spips: Use memset instead of a for loop to zero registers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, frederic.konrad@adacore.com, frasse.iglesias@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Use memset() instead of a for loop to zero all of the registers. Signed-off-by: Alistair Francis Reviewed-by: KONRAD Frederic Reviewed-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index b8182cfd74..59d42bfce7 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -329,10 +329,7 @@ static void xilinx_spips_reset(DeviceState *d) { XilinxSPIPS *s = XILINX_SPIPS(d); - int i; - for (i = 0; i < XLNX_SPIPS_R_MAX; i++) { - s->regs[i] = 0; - } + memset(s->regs, 0, sizeof(s->regs)); fifo8_reset(&s->rx_fifo); fifo8_reset(&s->rx_fifo); @@ -357,13 +354,11 @@ static void xilinx_spips_reset(DeviceState *d) static void xlnx_zynqmp_qspips_reset(DeviceState *d) { XlnxZynqMPQSPIPS *s = XLNX_ZYNQMP_QSPIPS(d); - int i; xilinx_spips_reset(d); - for (i = 0; i < XLNX_ZYNQMP_SPIPS_R_MAX; i++) { - s->regs[i] = 0; - } + memset(s->regs, 0, sizeof(s->regs)); + fifo8_reset(&s->rx_fifo_g); fifo8_reset(&s->rx_fifo_g); fifo32_reset(&s->fifo_g);