From patchwork Sat Jun 10 15:24:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamil Rytarowski X-Patchwork-Id: 774245 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wlNGB24l0z9sNN for ; Sun, 11 Jun 2017 01:23:13 +1000 (AEST) Received: from localhost ([::1]:58785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJiEE-0000iy-C7 for incoming@patchwork.ozlabs.org; Sat, 10 Jun 2017 11:23:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJiDl-0000it-NN for qemu-devel@nongnu.org; Sat, 10 Jun 2017 11:22:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJiDi-0001BM-Jt for qemu-devel@nongnu.org; Sat, 10 Jun 2017 11:22:37 -0400 Received: from mout.gmx.net ([212.227.15.15]:53956) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dJiDi-0001Au-8R; Sat, 10 Jun 2017 11:22:34 -0400 Received: from [192.168.1.3] ([185.58.161.191]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MaqeA-1dZifD1JGc-00KRaQ; Sat, 10 Jun 2017 17:22:17 +0200 To: Markus Armbruster References: <20170531120049.14111-1-n54@gmx.com> <26b48c35-b6cc-708d-c4d2-b26a9382e10a@msgid.tls.msk.ru> <877f0p38tr.fsf@dusky.pond.sub.org> <55dd32a9-7f01-93e3-e22e-3826dcef1d9d@gmx.com> <6620e2b9-6cc7-48fc-6ecf-4065718d765d@gmx.com> <87lgoz98mc.fsf@dusky.pond.sub.org> From: Kamil Rytarowski Message-ID: <03bf9574-79a4-0778-bb6d-e0a6da7d1d86@gmx.com> Date: Sat, 10 Jun 2017 17:24:28 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <87lgoz98mc.fsf@dusky.pond.sub.org> X-Provags-ID: V03:K0:PxP7Jz3kaB7ruKFVgAaPoaTO7fWPT2gmlTrUbY4FX9pbPB7pK+0 T+DJQCKISFEEBmIuuN1zPocr9WNb42gFzEi6VDCiSyjIBY8mlPWYTEz02mnBHWXJ3g3aeYV IzqME2dj/yOpXIlgp46GoVUf1oceX7oVbLlz8pYVCine+yCS/EoPJhQmyjonc8aWc4m5G+y r1PisFQYlTfVdaPFeBlRw== X-UI-Out-Filterresults: notjunk:1; V01:K0:9Lnj1K0mq1I=:7n/Dg0sDfbW4GpMa0yXYX2 nD2AkrWZP7g/NDTOn8w34eGuTD39gKpfvJz7ns0trO5bKbUGPasCaRB7/Jtg1wtIK3yMygWSl QvPedMet3Yu6sXNey0Nhh6/4senuLtR+a/URObSwohBY7xbf3cHl+YUlWF0OF1VbkIW7hHU4X 556+UlhxBrV72EC5uIowMkbSo6cheQAaALOzMqxE9bQ4jhXl2xILExNopvvhf7BeC5wuntsHy hvJSKd+uT7GyGPcwP6rONS4wzcSaU72oi+iA0DU4T4QiySmNnRle8PlcN1Xd8ZaD2UiNVp4Jd wnVjx8z1gCeVd/WZZbfr7v+UdveY4nsfRxrOUMGBTbG/LjsQk4O1TsJdidr5d4sb1SW0WgWEB 5ayqsTYyQ1hHUwQuYuJKkhef+MWkFDKWI6WUsQndZ/5q8FhuPlcEbU62cPJpLHxPOcsrqzEFz DAiyerBs6xLINbd/w2kl6VD07tu6ymBz1G90ZbVfybIDZqZhJKZKh2+g4j9gP2kE4FR0pRFWo 9tT6uIhg9jBETYYQ1uZ7TiOe3bLt/NO8G5T1vRZRMZ6femXWkFrBu9xEyEEq1cXYe3bfachIF ovb1q2nbiRwtkiDH4UEuSjuf4NffTR5s46yA5lCs6lgGfROgGqLd+J/JoA+3bhYexdosT15h+ TgzRNixTzFRNr6lCcf2mgrXyRr/3TriTbyolyIyX7OpUsogPXjF5o3S6AsDFGJNnm3lQRvKcD W9ezv/bbFVhzNi2jfKQkhs7Dx5nzfqvvyW2wP8f935Zo41AU7U0QD4CC9Co= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.15.15 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] ivshmem-server: ivshmem-client: Build when eventfd() is available X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Trivial , Michael Tokarev , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , QEMU Developers , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" On 10.06.2017 17:15, Markus Armbruster wrote: > Kamil Rytarowski writes: > >> On 06.06.2017 16:56, Kamil Rytarowski wrote: >>> On 06.06.2017 16:34, Peter Maydell wrote: >>>> On 6 June 2017 at 14:38, Kamil Rytarowski wrote: >>>>> I've linked qemu with the original patch and: >>>>> ./configure --disable-linux-user --disable-system --static >>>>> >>>>> I got some warnings, I think they are originated from our libc and are >>>>> not related to qemu: >>>>> LINK sparc64-bsd-user/qemu-sparc64 >>>>> /usr/lib/libc.a(initfini.o): warning: common of `__ps_strings' >>>>> overridden by definition >>>>> /usr/lib/crt0.o: warning: defined here >>>>> /usr/lib/libc.a(_env.o): warning: multiple common of `environ' >>>>> /usr/lib/crt0.o: warning: previous common is here >>>>> /usr/lib/libc.a(getprogname.o): warning: common of `__progname' >>>>> overridden by definition >>>>> /usr/lib/crt0.o: warning: defined here >>>> >>>> Yes, I think I've seen those before on NetBSD -- they look >>>> like a bug in your libc to me, it shouldn't be confusing itself >>>> with itself like that :-) >>>> >>>> thanks >>>> -- PMM >>>> >>> >>> I have filed this bug upstream: http://gnats.netbsd.org/52278 >>> >>> >> >> >> What's the status with this patch? >> >> NetBSD build still breaks due to ivshmem-*. > > I guess Michael expects a v4 that doesn't break the static build. > -static works for me, I have restricted options to test build on !NetBSD systems. Was this patch ok? diff --git a/Makefile b/Makefile index c830d7a..2ef5a78 100644 --- a/Makefile +++ b/Makefile @@ -469,10 +469,12 @@ ifneq ($(EXESUF),) qemu-ga: qemu-ga$(EXESUF) $(QGA_VSS_PROVIDER) $(QEMU_GA_MSI) endif +ifdef CONFIG_IVSHMEM ivshmem-client$(EXESUF): $(ivshmem-client-obj-y) $(COMMON_LDADDS) $(call LINK, $^) ivshmem-server$(EXESUF): $(ivshmem-server-obj-y) $(COMMON_LDADDS) $(call LINK, $^) +endif So I could amend it.