mbox series

[v2,0/1] ui/gtk: prevent QEMU lock up

Message ID d06fa203-5a89-b454-8b01-8711aaafeea2@t-online.de
Headers show
Series ui/gtk: prevent QEMU lock up | expand

Message

Volker Rümelin July 25, 2021, 4:46 p.m. UTC
Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple
characeters") it's very easy to lock up QEMU with the GTK ui.
If you configure a guest with a serial device and the guest
doesn't listen on this device, QEMU will lock up after
entering two characters in the serial console.

v2:
Gerd suggested to use the chr_accept_input() callback function
instead of a write retry timer and to drop patch 2/2.

Volker Rümelin (1):
   ui/gtk: add a keyboard fifo to the VTE consoles

  include/ui/gtk.h |  4 ++++
  ui/gtk.c         | 42 +++++++++++++++++++++++++++++++++---------
  2 files changed, 37 insertions(+), 9 deletions(-)

Comments

Gerd Hoffmann July 26, 2021, 8:28 a.m. UTC | #1
Hi,

> Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple
> characeters") it's very easy to lock up QEMU with the GTK ui.
> If you configure a guest with a serial device and the guest
> doesn't listen on this device, QEMU will lock up after
> entering two characters in the serial console.
> 
> v2:
> Gerd suggested to use the chr_accept_input() callback function
> instead of a write retry timer and to drop patch 2/2.

Very nice and easy to read patch now.

Queued up for 6.1.

thanks,
  Gerd