| Message ID | cover.1699793550.git.yong.huang@smartx.com |
|---|---|
| Headers | show |
| Series | vhost-user-test: Add negotiated features check | expand |
ping On Sun, Nov 12, 2023 at 9:03 PM Hyman Huang <yong.huang@smartx.com> wrote: > The patchset "Fix the virtio features negotiation flaw" fix a > vhost-user negotiation flaw: > c9bdc449f9 vhost-user: Fix the virtio features negotiation flaw > bebcac052a vhost-user: Refactor the chr_closed_bh > 937b7d96e4 vhost-user: Refactor vhost acked features saving > > While the test case remain unmerged, the detail reference: > > https://lore.kernel.org/qemu-devel/cover.1667232396.git.huangy81@chinatelecom.cn/ > > Since Michael pointed out that the info virtio makes sense to query > the negotiation feature, this patchset uses the x-query-virtio-status > to retrieve the features instead of exporting netdev capabilities and > information as we did in the previous patchset to aid in confirming > the negotiation's validity. > > To do that, we first introduce an "show-bits" argument for > x-query-virtio-status such that the feature bits can be used > directly, and then implement the test case for negotiated features > check. As we post, the code is divided into two patches. > > Please review, thanks, > Yong > > Hyman Huang (2): > qapi/virtio: introduce the "show-bits" argument for > x-query-virtio-status > vhost-user-test: Add negotiated features check > > hw/virtio/virtio-hmp-cmds.c | 2 +- > hw/virtio/virtio-qmp.c | 21 ++++++- > qapi/virtio.json | 49 ++++++++++++++++- > tests/qtest/vhost-user-test.c | 100 ++++++++++++++++++++++++++++++++++ > 4 files changed, 167 insertions(+), 5 deletions(-) > > -- > 2.39.1 > >
On Thu, Nov 16, 2023 at 09:01:28AM +0800, Yong Huang wrote:
> ping
Sit tight pls it's only been a couple of days.
But if you want to, address comments by Markus pls.
On Fri, Nov 17, 2023 at 6:29 PM Michael S. Tsirkin <mst@redhat.com> wrote: > On Thu, Nov 16, 2023 at 09:01:28AM +0800, Yong Huang wrote: > > ping > > Sit tight pls it's only been a couple of days. > But if you want to, address comments by Markus pls. > > I'm happy to do that, of course, and thank you also for the reminder. :)
The patchset "Fix the virtio features negotiation flaw" fix a vhost-user negotiation flaw: c9bdc449f9 vhost-user: Fix the virtio features negotiation flaw bebcac052a vhost-user: Refactor the chr_closed_bh 937b7d96e4 vhost-user: Refactor vhost acked features saving While the test case remain unmerged, the detail reference: https://lore.kernel.org/qemu-devel/cover.1667232396.git.huangy81@chinatelecom.cn/ Since Michael pointed out that the info virtio makes sense to query the negotiation feature, this patchset uses the x-query-virtio-status to retrieve the features instead of exporting netdev capabilities and information as we did in the previous patchset to aid in confirming the negotiation's validity. To do that, we first introduce an "show-bits" argument for x-query-virtio-status such that the feature bits can be used directly, and then implement the test case for negotiated features check. As we post, the code is divided into two patches. Please review, thanks, Yong Hyman Huang (2): qapi/virtio: introduce the "show-bits" argument for x-query-virtio-status vhost-user-test: Add negotiated features check hw/virtio/virtio-hmp-cmds.c | 2 +- hw/virtio/virtio-qmp.c | 21 ++++++- qapi/virtio.json | 49 ++++++++++++++++- tests/qtest/vhost-user-test.c | 100 ++++++++++++++++++++++++++++++++++ 4 files changed, 167 insertions(+), 5 deletions(-)