From patchwork Sun Apr 26 19:25:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Straub X-Patchwork-Id: 1277204 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=web.de header.i=@web.de header.a=rsa-sha256 header.s=dbaedf251592 header.b=LJIOm0FK; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 499J061Y1Wz9sRf for ; Mon, 27 Apr 2020 05:30:12 +1000 (AEST) Received: from localhost ([::1]:43512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSmyd-0001B2-Jc for incoming@patchwork.ozlabs.org; Sun, 26 Apr 2020 15:30:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47672) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSmuU-0001Ae-Ic for qemu-devel@nongnu.org; Sun, 26 Apr 2020 15:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSmuT-0005cZ-VM for qemu-devel@nongnu.org; Sun, 26 Apr 2020 15:25:50 -0400 Received: from mout.web.de ([212.227.15.3]:57637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jSmuT-0005b4-8X for qemu-devel@nongnu.org; Sun, 26 Apr 2020 15:25:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587929135; bh=mkZVV6LtsoPFVdmtzzWwTA750eKiRLqCznFGLokBVh0=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject; b=LJIOm0FKp1Cl+vzwtLBlT34AcEQM7JPeTDu9Du8A5jW8lxquDJkv/H4tbv3aLDqla j4+iyDCexjXBSMOeokKONMkk5bcRyWjmcOqON4TadCLi8PG7FAt/sK/dlb0r71+rIJ UWnVjcLygug+k1XFCB1CCONRH+CpwDSrQ2WIETOs= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from luklap ([89.247.255.95]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LfidG-1irnSG30O2-00pN31; Sun, 26 Apr 2020 21:25:34 +0200 Date: Sun, 26 Apr 2020 21:25:23 +0200 From: Lukas Straub To: qemu-devel Subject: [PATCH v2 0/6] colo-compare bugfixes Message-ID: MIME-Version: 1.0 X-Provags-ID: V03:K1:UpEPzzjDZjy+eWo+B6899hOCYyrT4IYf8To0DiOrDxESXWQUml5 o3ylY2mStQ3kDZu3s4eg0oTNxgF/BirQS5cUZYfsN9giPm4STNwZHnJtv0+b0GYTFfwX+gp X5fl+TD0RjbbYGJg3rmygLgohq1TWDODS9v1kc+atYHHgUghZ5fy//xZbwXRqGFuPjEJB/z lXfuWRWYK84S5icyJ3QOg== X-UI-Out-Filterresults: notjunk:1;V03:K0:evVsrSQZP7o=:t5tCtEdjm2kh5oGtRnBbs4 MqUBROos5v3S9pZLWOSprwl5RqqC8bIT3YIdcnbGdbI31W+5KCUGa2IDoDBDy3+0EtvKSDfhP 5OdsKKyRNk0cTTIKLg14PxdlQA/M2KOOSc1CyzhYcLrAlCLCmXISIigDIYYLd5xvxJJGbtZMs ytJ5ISRVY7CaEqTBZvTFgVNe+T4xaBPr5XE2iXm+dvtzVoFiScaqEHCw/27XyR8pxPRw/E1z5 NRieiZDQeEBsH0nQneDIfWGBQAUDZPvCce3CBYziClEsmnhlDNSLb3kfSnru9v0pTLUpT9OZv wveHmE9Cobgi/yKoYbAn6GrgGcFHZT73yYjlRfX0DB34C2eCrWgXcOuo8besg9mVTeSy419Zl TAXi1+ZreNIFtuKQfhYaOgEfyb/z4cgdfcz4W8po1L5oFWN6GvQngNPdfDMrNupcfLxcv/8W3 /1BhfRwK1GO3PZMopv7hjA250paHINyOVMIqXlXpV4plxKm8JXLj4iq7NC90ChYbUuTIsn4va gMJ829VjGg8JroM4pn+14AI5A2of25sVc8ih4Q2umJnpnrwardyLZwkRMK9MrB5CjIaKX26eq pyyTyUywi8kE6EvuBDjH2c8OEr9LMWPMTk2H4lyzIRWuJXMI1Czi0qujnYpZ3oUS3ESZRLmRs 0mOFLuE6cMqz+AQZeD8kfsV1FbsSme8NJ+oa8FsAQtMPcYYQyz0bKjhVppO/eaSHbqo0ZPQX8 rYk9WgydtU0fwhODwTIU3mzY8/HkdvpcBH8x4W5TgIgRuMAmpEo4y7loiiv1p+jsJZjpNvvYW LCg31c4koJlmFgCrN97PByJ9NMy7xlq4aadMq+/xOQOp99zco3dSkDU0SsJUoChNzRKcJclP6 YyzwZ3ozKPxz6KgeZxukr/XCK+cImGGJuVNn1iTXCVOb6AOWt1eAf/DvnhoepO2QqLA2BC0nj oQUsoNeisFUzRTlIVXqLViVESG9eyB638YUfutTTSiT+JBuhZfKNeV/ZfJOjV0vH7s0zTntVE lFw6rCuvCsNmebtoyuGzyuPqBsLVbth7Wg9CN/IhxdVUIJ8FX/IcMIGUcMafYnNBexkvNeTx1 5p4M7ItdLN3lL7/h00pEV+ZICycDfhtpedAVyJ9B2oMfB/+rcHUUbI5NdXaNZYqjNwTK0Ip4d qwCN/3fY3ZDvIMHrLbdBUC0o4HN5r4FkLaal3ociIkp3Ppf/tfC/u5y5dwr3NrQlNmdLgGcIi LpIhdFryQrzzuRp43 Received-SPF: pass client-ip=212.227.15.3; envelope-from=lukasstraub2@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/26 15:25:46 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Received-From: 212.227.15.3 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Jason Wang , Paolo Bonzini , Li Zhijian , =?utf-8?q?Marc-Andr=C3=A9?= Lureau Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hello Everyone, The performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in compare_chr_send", has been fixed in this version by putting the packets in a queue instead of returning error. I also found and fixed some more bugs. Benchmark results: Client-to-server tcp: without patch: ~63 Mbit/s with patch: ~66 Mbit/s Server-to-client tcp: without patch: ~771 Kbit/s with patch: ~702 Kbit/s Regards, Lukas Straub Changes in v2: -better wording -fix performance-regression in patch 3 "net/colo-compare.c: Fix deadlock in compare_chr_send" -add more bugfixes Lukas Straub (6): net/colo-compare.c: Create event_bh with the right AioContext chardev/char.c: Use qemu_co_sleep_ns if in coroutine net/colo-compare.c: Fix deadlock in compare_chr_send net/colo-compare.c: Only hexdump packets if tracing is enabled net/colo-compare.c, softmmu/vl.c: Check that colo-compare is active net/colo-compare.c: Correct ordering in complete and finalize chardev/char.c | 7 +- net/colo-compare.c | 237 +++++++++++++++++++++++++++++++++------------ net/colo-compare.h | 1 + softmmu/vl.c | 2 + 4 files changed, 184 insertions(+), 63 deletions(-)