From patchwork Wed Jan 29 09:27:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Finn Thain X-Patchwork-Id: 1230773 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=telegraphics.com.au Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 486z552yCcz9sNT for ; Wed, 29 Jan 2020 20:41:13 +1100 (AEDT) Received: from localhost ([::1]:43352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwjqR-0006KK-Cf for incoming@patchwork.ozlabs.org; Wed, 29 Jan 2020 04:41:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51766) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwjlO-0004LY-Kn for qemu-devel@nongnu.org; Wed, 29 Jan 2020 04:35:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwjlN-0001Df-Fe for qemu-devel@nongnu.org; Wed, 29 Jan 2020 04:35:58 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:50030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iwjlN-0000jK-AQ; Wed, 29 Jan 2020 04:35:57 -0500 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 1A37A299AD; Wed, 29 Jan 2020 04:35:35 -0500 (EST) Message-Id: From: Finn Thain Subject: [PATCH v4 00/14] Fixes for DP8393X SONIC device emulation MIME-Version: 1.0 Date: Wed, 29 Jan 2020 20:27:49 +1100 To: Jason Wang , qemu-devel@nongnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 98.124.60.144 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Herv=C3=A9_Poussineau?= , Aleksandar Rikalo , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= , Laurent Vivier , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi All, There are bugs in the emulated dp8393x device that can stop packet reception in a Linux/m68k guest (q800 machine). With a Linux/m68k v5.5 guest (q800), it's possible to remotely trigger an Oops by sending ping floods. With a Linux/mips guest (magnum machine), the driver fails to probe the dp8393x device. With a NetBSD/arc 5.1 guest (magnum), the bugs in the device can be fatal to the guest kernel. Whilst debugging the device, I found that the receiver algorithm differs from the one described in the National Semiconductor datasheet. This patch series resolves these bugs. AFAIK, all bugs in the Linux sonic driver were fixed in Linux v5.5. --- Changed since v1: - Minor revisions as described beneath commit logs. - Dropped patches 4/10 and 7/10. - Added 5 new patches. Changed since v2: - Minor revisions as described beneath commit logs. - Dropped patch 13/13. - Added 2 new patches. Changed since v3: - Replaced patch 13/14 with patch suggested by Philippe Mathieu-Daudé. Finn Thain (14): dp8393x: Mask EOL bit from descriptor addresses dp8393x: Always use 32-bit accesses dp8393x: Clean up endianness hacks dp8393x: Have dp8393x_receive() return the packet size dp8393x: Update LLFA and CRDA registers from rx descriptor dp8393x: Clear RRRA command register bit only when appropriate dp8393x: Implement packet size limit and RBAE interrupt dp8393x: Don't clobber packet checksum dp8393x: Use long-word-aligned RRA pointers in 32-bit mode dp8393x: Pad frames to word or long word boundary dp8393x: Clear descriptor in_use field to release packet dp8393x: Always update RRA pointers and sequence numbers dp8393x: Don't reset Silicon Revision register dp8393x: Don't stop reception upon RBE interrupt assertion hw/net/dp8393x.c | 202 +++++++++++++++++++++++++++++++---------------- 1 file changed, 134 insertions(+), 68 deletions(-)