From patchwork Sat Dec 14 01:25:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Finn Thain X-Patchwork-Id: 1209586 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=telegraphics.com.au Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47ZVM81xS6z9sR0 for ; Sat, 14 Dec 2019 12:29:40 +1100 (AEDT) Received: from localhost ([::1]:54942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifwFV-00046V-GA for incoming@patchwork.ozlabs.org; Fri, 13 Dec 2019 20:29:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41454) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifwEd-00041r-Qt for qemu-devel@nongnu.org; Fri, 13 Dec 2019 20:28:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifwEc-00018v-Fp for qemu-devel@nongnu.org; Fri, 13 Dec 2019 20:28:43 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:47370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ifwEc-00014n-56; Fri, 13 Dec 2019 20:28:42 -0500 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id D74FD22CA2; Fri, 13 Dec 2019 20:28:40 -0500 (EST) Message-Id: From: Finn Thain Subject: [PATCH 00/10] Fixes for DP8393X SONIC device emulation Date: Sat, 14 Dec 2019 12:25:57 +1100 To: Jason Wang , qemu-devel@nongnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 98.124.60.144 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Herve Poussineau , Laurent Vivier , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Hi All, There is a bug in the DP8393X emulation that can stop packet reception. Whilst debugging that issue I found that the receiver algorithm differs from the one described in the National Semiconductor datasheet. These issues and others are addressed by this patch series. This series has only been tested with Linux/m68k guests. It needs further testing with MIPS Jazz guests such as NetBSD or Windows NT. Thanks. Finn Thain (10): dp8393x: Mask EOL bit from descriptor addresses dp8393x: Clean up endianness hacks dp8393x: Have dp8393x_receive() return the packet size dp8393x: Don't advance RX descriptor twice dp8393x: Update LLFA register dp8393x: Clear RRRA command register bit only when appropriate dp8393x: Implement TBWC0 and TBWC1 registers to restore buffer state dp8393x: Implement packet size limit and RBAE interrupt dp8393x: Don't stop reception upon RBE interrupt assertion dp8393x: Don't clobber packet checksum hw/net/dp8393x.c | 80 +++++++++++++++++++++++++++++++----------------- 1 file changed, 52 insertions(+), 28 deletions(-)