mbox series

[0/3] Audio: misc fixes for "Audio 20190821 patches", part two

Message ID cover.1568157545.git.DirtY.iCE.hu@gmail.com
Headers show
Series Audio: misc fixes for "Audio 20190821 patches", part two | expand

Message

=?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?= Sept. 10, 2019, 11:26 p.m. UTC 
Hi,

This series contains some random fixes for the "Audio 20190821 patches":
a coverity bugfix and pulseaudio connection/stream names fix.

Since there wasn't a clear consensus about naming the pa streams, I've
split it into two commits: the first time just uses the audiodev id
unconditionally, while the last commit adds a new option to qapi to
override it.  This way we can easily drop the last commit if it turns
out to be unnecessary.

Regards,
Zoltan


Kővágó, Zoltán (3):
  audio: fix parameter dereference before NULL check
  audio: paaudio: fix connection and stream name
  audio: paaudio: ability to specify stream name

 audio/audio_template.h | 7 +++++--
 audio/paaudio.c        | 9 ++++++---
 qapi/audio.json        | 6 ++++++
 3 files changed, 17 insertions(+), 5 deletions(-)

Comments

Peter Maydell Oct. 17, 2019, 12:07 p.m. UTC | #1 
Hi -- not sure what's happened with this patchset, but
can we at least get the first patch (which fixes some
coverity errors) in, even if the other two need more
consideration?

(cc'ing Gerd as audio maintainer.)

thanks
-- PMM


On Wed, 11 Sep 2019 at 00:27, Kővágó, Zoltán <dirty.ice.hu@gmail.com> wrote:
>
> Hi,
>
> This series contains some random fixes for the "Audio 20190821 patches":
> a coverity bugfix and pulseaudio connection/stream names fix.
>
> Since there wasn't a clear consensus about naming the pa streams, I've
> split it into two commits: the first time just uses the audiodev id
> unconditionally, while the last commit adds a new option to qapi to
> override it.  This way we can easily drop the last commit if it turns
> out to be unnecessary.
>
> Regards,
> Zoltan
>
>
> Kővágó, Zoltán (3):
>   audio: fix parameter dereference before NULL check
>   audio: paaudio: fix connection and stream name
>   audio: paaudio: ability to specify stream name
>
>  audio/audio_template.h | 7 +++++--
>  audio/paaudio.c        | 9 ++++++---
>  qapi/audio.json        | 6 ++++++
>  3 files changed, 17 insertions(+), 5 deletions(-)