| Message ID | cfc5a196-9939-44b5-8716-9525f1a08a2a@t-online.de |
|---|---|
| Headers | show |
| Series | hw/audio/es1370: bug fix | expand |
Hi On Sun, Sep 17, 2023 at 10:55 AM Volker Rümelin <vr_qemu@t-online.de> wrote: > > Cc: qemu-stable. Patch 1/8 is a bug fix. > Cc: more people. The maintainer of hw/audio is busy with other projects. > > Earlier this year I was asked if I could help to debug an audio playback > speed issue with the es1370 device. While debugging the playback speed > error, I noticed that the debug code of the ES1370 device has not been > compiled for a long time and has bit-rotted. This patch series fixes the > rotten code and also fixes a bug I found while debugging the code. The > bug fix is in patch 1/8 and prevents corrupted data streams. The > playback speed issue was caused by lost interrupts. Patch 8/8 helps to > debug this kind of issues. > > Volker Rümelin (8): > hw/audio/es1370: reset current sample counter > hw/audio/es1370: replace bit-rotted code with tracepoints > hw/audio/es1370: remove unused dolog macro > hw/audio/es1370: remove #ifdef ES1370_DEBUG to avoid bit rot > hw/audio/es1370: remove #ifdef ES1370_VERBOSE to avoid bit rot > hw/audio/es1370: block structure coding style fixes > hw/audio/es1370: change variable type and name > hw/audio/es1370: trace lost interrupts > > hw/audio/es1370.c | 289 +++++++++++++++++++----------------------- > hw/audio/trace-events | 11 ++ > 2 files changed, 143 insertions(+), 157 deletions(-) > > -- > 2.35.3 > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
On Sun, 17 Sep 2023, Volker Rümelin wrote: > Cc: qemu-stable. Patch 1/8 is a bug fix. > Cc: more people. The maintainer of hw/audio is busy with other projects. > > Earlier this year I was asked if I could help to debug an audio playback > speed issue with the es1370 device. While debugging the playback speed > error, I noticed that the debug code of the ES1370 device has not been > compiled for a long time and has bit-rotted. This patch series fixes the > rotten code and also fixes a bug I found while debugging the code. The > bug fix is in patch 1/8 and prevents corrupted data streams. The > playback speed issue was caused by lost interrupts. Patch 8/8 helps to > debug this kind of issues. > > Volker Rümelin (8): > hw/audio/es1370: reset current sample counter > hw/audio/es1370: replace bit-rotted code with tracepoints > hw/audio/es1370: remove unused dolog macro > hw/audio/es1370: remove #ifdef ES1370_DEBUG to avoid bit rot > hw/audio/es1370: remove #ifdef ES1370_VERBOSE to avoid bit rot > hw/audio/es1370: block structure coding style fixes > hw/audio/es1370: change variable type and name > hw/audio/es1370: trace lost interrupts > > hw/audio/es1370.c | 289 +++++++++++++++++++----------------------- > hw/audio/trace-events | 11 ++ > 2 files changed, 143 insertions(+), 157 deletions(-) Tested-by: BALATON Zoltan <balaton@eik.bme.hu> The whole series also got a reirwed-by from Marc-Andre already so maybe Gerd should have a look merging this. Regards, BALATON Zoltan
Hi On Tue, Oct 10, 2023 at 4:26 PM BALATON Zoltan <balaton@eik.bme.hu> wrote: > > On Sun, 17 Sep 2023, Volker Rümelin wrote: > > Cc: qemu-stable. Patch 1/8 is a bug fix. > > Cc: more people. The maintainer of hw/audio is busy with other projects. > > > > Earlier this year I was asked if I could help to debug an audio playback > > speed issue with the es1370 device. While debugging the playback speed > > error, I noticed that the debug code of the ES1370 device has not been > > compiled for a long time and has bit-rotted. This patch series fixes the > > rotten code and also fixes a bug I found while debugging the code. The > > bug fix is in patch 1/8 and prevents corrupted data streams. The > > playback speed issue was caused by lost interrupts. Patch 8/8 helps to > > debug this kind of issues. > > > > Volker Rümelin (8): > > hw/audio/es1370: reset current sample counter > > hw/audio/es1370: replace bit-rotted code with tracepoints > > hw/audio/es1370: remove unused dolog macro > > hw/audio/es1370: remove #ifdef ES1370_DEBUG to avoid bit rot > > hw/audio/es1370: remove #ifdef ES1370_VERBOSE to avoid bit rot > > hw/audio/es1370: block structure coding style fixes > > hw/audio/es1370: change variable type and name > > hw/audio/es1370: trace lost interrupts > > > > hw/audio/es1370.c | 289 +++++++++++++++++++----------------------- > > hw/audio/trace-events | 11 ++ > > 2 files changed, 143 insertions(+), 157 deletions(-) > > Tested-by: BALATON Zoltan <balaton@eik.bme.hu> > > The whole series also got a reirwed-by from Marc-Andre already so maybe > Gerd should have a look merging this. I am going to send a PR. thanks