| Message ID | 20241111-queue-v2-0-2f7883a1004f@daynix.com |
|---|---|
| Headers | show |
| Series | virtio-net fixes | expand |
11.11.2024 09:40, Akihiko Odaki wrote: > Most of this series are fixes for software RSS and hash reporting, which > should have no production user. > > However there is one exception; patch "virtio-net: Fix size check in > dhclient workaround" fixes an out-of-bound access that can be triggered > for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and > can be applied independently. Hi! Do you plan to submit this and "virtio-net: Add queues before loading them" for 9.2, which is at rc1 now already? Thanks, /mjt
On 2024/11/21 19:05, Michael Tokarev wrote: > 11.11.2024 09:40, Akihiko Odaki wrote: >> Most of this series are fixes for software RSS and hash reporting, which >> should have no production user. >> >> However there is one exception; patch "virtio-net: Fix size check in >> dhclient workaround" fixes an out-of-bound access that can be triggered >> for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and >> can be applied independently. > > Hi! Do you plan to submit this and "virtio-net: Add queues before > loading them" > for 9.2, which is at rc1 now already? I want "[PATCH v2 2/6] virtio-net: Fix size check in dhclient workaround" and "virtio-net: Add queues before loading them" for 9.2. They have Cc: qemu-stable@nongnu.org and will need backporting if it misses 9.2.0. Regards, Akihiko Odaki
On Thu, Nov 21, 2024 at 6:09 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote: > > On 2024/11/21 19:05, Michael Tokarev wrote: > > 11.11.2024 09:40, Akihiko Odaki wrote: > >> Most of this series are fixes for software RSS and hash reporting, which > >> should have no production user. > >> > >> However there is one exception; patch "virtio-net: Fix size check in > >> dhclient workaround" fixes an out-of-bound access that can be triggered > >> for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and > >> can be applied independently. > > > > Hi! Do you plan to submit this and "virtio-net: Add queues before > > loading them" > > for 9.2, which is at rc1 now already? > > I want "[PATCH v2 2/6] virtio-net: Fix size check in dhclient > workaround" and "virtio-net: Add queues before loading them" for 9.2. > > They have Cc: qemu-stable@nongnu.org and will need backporting if it > misses 9.2.0. > > Regards, > Akihiko Odaki > Want to apply this series but patch 4 doesn't applied cleanly, please rebase and send a new version: Applying: net: checksum: Convert data to void * Applying: virtio-net: Fix size check in dhclient workaround Applying: virtio-net: Do not check for the queue before RSS Applying: virtio-net: Fix hash reporting when the queue changes error: patch failed: hw/net/virtio-net.c:2044 error: hw/net/virtio-net.c: patch does not apply Patch failed at 0004 virtio-net: Fix hash reporting when the queue changes hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Thanks
Most of this series are fixes for software RSS and hash reporting, which should have no production user. However there is one exception; patch "virtio-net: Fix size check in dhclient workaround" fixes an out-of-bound access that can be triggered for anyone who don't use vhost. It has Cc: qemu-stable@nongnu.org and can be applied independently. Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com> --- Changes in v2: - Dropped patch "virtio-net: Fix num_buffers for version 1" in favor of fixing the spec. See: https://lore.kernel.org/r/CACGkMEt0spn59oLyoCwcJDdLeYUEibePF7gppxdVX1YvmAr72Q@mail.gmail.com - Added a Buglink to patch "virtio-net: Fix hash reporting when the queue changes". - Rebased. - Link to v1: https://lore.kernel.org/r/20240915-queue-v1-0-b49bd49b926d@daynix.com --- Akihiko Odaki (6): net: checksum: Convert data to void * virtio-net: Fix size check in dhclient workaround virtio-net: Do not check for the queue before RSS virtio-net: Fix hash reporting when the queue changes virtio-net: Initialize hash reporting values virtio-net: Copy received header to buffer include/net/checksum.h | 2 +- hw/net/virtio-net.c | 108 +++++++++++++++++++++++++++---------------------- net/checksum.c | 4 +- 3 files changed, 63 insertions(+), 51 deletions(-) --- base-commit: 7e3b6d8063f245d27eecce5aabe624b5785f2a77 change-id: 20240907-queue-f425937a730f Best regards,