From patchwork Tue Aug 6 16:07:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juraj Marcin X-Patchwork-Id: 1969630 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HPr+P6XF; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WddYJ54WZz1yYD for ; Wed, 7 Aug 2024 02:09:40 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbMkb-00078B-1v; Tue, 06 Aug 2024 12:09:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbMkT-00070m-VG for qemu-devel@nongnu.org; Tue, 06 Aug 2024 12:09:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbMkR-0002rC-Ud for qemu-devel@nongnu.org; Tue, 06 Aug 2024 12:09:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722960552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tTq4GfQT2ouFm1PtBpBszPbPQmd8iUNYQ3d6LL2OH4c=; b=HPr+P6XFbz5F+ZvRv7dNAkCiPUWBQZcn8Gs/Mo7Jzv1ogouo62pMgeX31YHEekTsEKYZJz zxFUfTNlSMzISPJR0IHHZHo6NwIgsCKoEFtaTuDHjuj/2A8A0W4YuxNFxdHQX4A2V5VAto j8iJKNWuRTM7qtSeO4HWRrgWvornKGM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-tPqePAqnPBS3Cj0Bvp6ZBg-1; Tue, 06 Aug 2024 12:08:00 -0400 X-MC-Unique: tPqePAqnPBS3Cj0Bvp6ZBg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6100D1956064; Tue, 6 Aug 2024 16:07:59 +0000 (UTC) Received: from rh-jmarcin.brq.redhat.com (unknown [10.43.2.64]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9A1F11955D44; Tue, 6 Aug 2024 16:07:57 +0000 (UTC) From: Juraj Marcin To: qemu-devel@nongnu.org Cc: David Hildenbrand , Peter Maydell Subject: [PATCH 0/4] virtio-mem: Implement support for suspend+wake-up with plugged memory Date: Tue, 6 Aug 2024 18:07:50 +0200 Message-ID: <20240806160756.182524-1-jmarcin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=jmarcin@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.144, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Currently, the virtio-mem device would unplug all the memory with any reset request, including when the machine wakes up from a suspended state (deep sleep). This would lead to a loss of the contents of the guest memory and therefore is disabled by the virtio-mem Linux Kernel driver unless the VIRTIO_MEM_F_PERSISTENT_SUSPEND virtio feature is exposed. [1] To make deep sleep with virtio-mem possible, we need to differentiate cold start reset from wake-up reset. The first patch updates qemu_system_reset() and MachineClass children to accept ResetType instead of ShutdownCause, which then could be passed down the device tree. The second patch then introduces the new reset type for the wake-up event and updates the i386 wake-up method (only architecture using the explicit wake-up method). The third patch replaces LegacyReset with the Resettable interface in virtio-mem, so the memory device can access the reset type in the hold phase. The last patch of the series implements the final support in the hold phase of the virtio-mem reset callback and exposes VIRTIO_MEM_F_PERSISTENT_SUSPEND to the kernel. [1]: https://lore.kernel.org/all/20240318120645.105664-1-david@redhat.com/ Juraj Marcin (4): reset: Use ResetType for qemu_devices_reset() and MachineClass->reset() reset: Add RESET_TYPE_WAKEUP virtio-mem: Implement Resettable interface instead of using LegacyReset virtio-mem: Add support for suspend+wake-up with plugged memory docs/devel/reset.rst | 7 +++++ hw/arm/aspeed.c | 4 +-- hw/arm/mps2-tz.c | 4 +-- hw/core/reset.c | 7 ++--- hw/hppa/machine.c | 4 +-- hw/i386/microvm.c | 4 +-- hw/i386/pc.c | 6 ++--- hw/ppc/pegasos2.c | 4 +-- hw/ppc/pnv.c | 4 +-- hw/ppc/spapr.c | 6 ++--- hw/s390x/s390-virtio-ccw.c | 4 +-- hw/virtio/virtio-mem.c | 49 ++++++++++++++++++++++++---------- hw/virtio/virtio-qmp.c | 3 +++ include/hw/boards.h | 3 ++- include/hw/resettable.h | 2 ++ include/hw/virtio/virtio-mem.h | 4 +++ include/sysemu/reset.h | 5 ++-- system/runstate.c | 13 +++++++-- 18 files changed, 89 insertions(+), 44 deletions(-)