mbox series

[v4,0/4] VT-d minor fixes

Message ID 20240705105937.1630829-1-clement.mathieu--drif@eviden.com
Headers show
Series VT-d minor fixes | expand

Message

CLEMENT MATHIEU--DRIF July 5, 2024, 11:01 a.m. UTC
From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>

Various fixes for VT-d

This series contains fixes that will be necessary
when adding in-guest (fully emulated) SVM support.

v4
    - Move declarations of VTD_FRCD_PV and VTD_FRCD_PP
    - intel_iommu: make types match:
    	- edit commit message to explain that we are not fixing a bug
    - intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
    	- edit commit message

v3
    FRCD construction macro :
    	- Longer sha1 for the 'Fixes' tag
    	- Add '.' at the end of the sentence
    
    Make types match :
    	- Split into 2 patches (one for the fix and one for type matching)
    
    Remove patch for wait descriptor handling (will be in the PRI series)

v2
    Make commit author consistent



Clément Mathieu--Drif (4):
  intel_iommu: fix FRCD construction macro
  intel_iommu: move VTD_FRCD_PV and VTD_FRCD_PP declarations
  intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
  intel_iommu: make types match

 hw/i386/intel_iommu.c          | 2 +-
 hw/i386/intel_iommu_internal.h | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Michael S. Tsirkin July 20, 2024, 6:44 p.m. UTC | #1
On Fri, Jul 05, 2024 at 11:01:55AM +0000, CLEMENT MATHIEU--DRIF wrote:
> From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
> 
> Various fixes for VT-d
> 
> This series contains fixes that will be necessary
> when adding in-guest (fully emulated) SVM support.

Clément are you going to address Yi Liu's comments?

> v4
>     - Move declarations of VTD_FRCD_PV and VTD_FRCD_PP
>     - intel_iommu: make types match:
>     	- edit commit message to explain that we are not fixing a bug
>     - intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
>     	- edit commit message
> 
> v3
>     FRCD construction macro :
>     	- Longer sha1 for the 'Fixes' tag
>     	- Add '.' at the end of the sentence
>     
>     Make types match :
>     	- Split into 2 patches (one for the fix and one for type matching)
>     
>     Remove patch for wait descriptor handling (will be in the PRI series)
> 
> v2
>     Make commit author consistent
> 
> 
> 
> Clément Mathieu--Drif (4):
>   intel_iommu: fix FRCD construction macro
>   intel_iommu: move VTD_FRCD_PV and VTD_FRCD_PP declarations
>   intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
>   intel_iommu: make types match
> 
>  hw/i386/intel_iommu.c          | 2 +-
>  hw/i386/intel_iommu_internal.h | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.45.2
Michael S. Tsirkin July 20, 2024, 7:08 p.m. UTC | #2
On Sat, Jul 20, 2024 at 02:44:18PM -0400, Michael S. Tsirkin wrote:
> On Fri, Jul 05, 2024 at 11:01:55AM +0000, CLEMENT MATHIEU--DRIF wrote:
> > From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
> > 
> > Various fixes for VT-d
> > 
> > This series contains fixes that will be necessary
> > when adding in-guest (fully emulated) SVM support.
> 
> Clément are you going to address Yi Liu's comments?


sorry this is old version, pls ignore

> > v4
> >     - Move declarations of VTD_FRCD_PV and VTD_FRCD_PP
> >     - intel_iommu: make types match:
> >     	- edit commit message to explain that we are not fixing a bug
> >     - intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
> >     	- edit commit message
> > 
> > v3
> >     FRCD construction macro :
> >     	- Longer sha1 for the 'Fixes' tag
> >     	- Add '.' at the end of the sentence
> >     
> >     Make types match :
> >     	- Split into 2 patches (one for the fix and one for type matching)
> >     
> >     Remove patch for wait descriptor handling (will be in the PRI series)
> > 
> > v2
> >     Make commit author consistent
> > 
> > 
> > 
> > Clément Mathieu--Drif (4):
> >   intel_iommu: fix FRCD construction macro
> >   intel_iommu: move VTD_FRCD_PV and VTD_FRCD_PP declarations
> >   intel_iommu: fix type of the mask field in VTDIOTLBPageInvInfo
> >   intel_iommu: make types match
> > 
> >  hw/i386/intel_iommu.c          | 2 +-
> >  hw/i386/intel_iommu_internal.h | 6 +++---
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > -- 
> > 2.45.2