mbox series

[0/2] block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked

Message ID 20240627181245.281403-1-kwolf@redhat.com
Headers show
Series block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked | expand

Message

Kevin Wolf June 27, 2024, 6:12 p.m. UTC 
Newer clang versions allow us to check scoped guards more thoroughly.
Surprisingly, we only seem to have missed one instance with the old
incomplete checks.

Kevin Wolf (2):
  block-copy: Fix missing graph lock
  block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked

 include/block/graph-lock.h | 21 ++++++++++++++-------
 block/block-copy.c         |  4 +++-
 meson.build                | 14 +++++++++++++-
 3 files changed, 30 insertions(+), 9 deletions(-)

Comments

Stefan Hajnoczi July 11, 2024, 6:07 a.m. UTC | #1 
On Thu, Jun 27, 2024 at 08:12:43PM +0200, Kevin Wolf wrote:
> Newer clang versions allow us to check scoped guards more thoroughly.
> Surprisingly, we only seem to have missed one instance with the old
> incomplete checks.
> 
> Kevin Wolf (2):
>   block-copy: Fix missing graph lock
>   block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked
> 
>  include/block/graph-lock.h | 21 ++++++++++++++-------
>  block/block-copy.c         |  4 +++-
>  meson.build                | 14 +++++++++++++-
>  3 files changed, 30 insertions(+), 9 deletions(-)
> 
> -- 
> 2.45.2
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>