mbox series

[v1,00/16] vfio: QOMify VFIOContainer

Message ID 20240612130122.813935-1-clg@redhat.com
Headers show
Series vfio: QOMify VFIOContainer | expand

Message

Cédric Le Goater June 12, 2024, 1:01 p.m. UTC 
Hello,

The series starts with simple changes (patch 1-4). Two of which were
initialy sent by Joao in a series adding VFIO migration support with
vIOMMU [1].

The changes following prepare VFIOContainer for QOMification, switch
the container models to QOM when ready and add some final cleanups.

Thanks,

C.

[1] https://lore.kernel.org/qemu-devel/20230622214845.3980-1-joao.m.martins@oracle.com/


Avihai Horon (1):
  vfio/common: Extract vIOMMU code from vfio_sync_dirty_bitmap()

Cédric Le Goater (14):
  vfio: Make vfio_devices_dma_logging_start() return bool
  vfio: Remove unused declarations from vfio-common.h
  vfio/container: Introduce vfio_address_space_insert()
  vfio/container: Simplify vfio_container_init()
  vfio/container: Modify vfio_get_iommu_type() to use a container fd
  vfio/container: Introduce vfio_get_iommu_class_name()
  vfio/container: Introduce vfio_create_container()
  vfio/container: Discover IOMMU type before creating the container
  vfio/container: Change VFIOContainerBase to use QOM
  vfio/container: Switch to QOM
  vfio/container: Introduce an instance_init() handler
  vfio/container: Remove VFIOContainerBase::ops
  vfio/container: Remove vfio_container_init()
  vfio/container: Introduce vfio_iommu_legacy_instance_init()

Joao Martins (1):
  vfio/common: Move dirty tracking ranges update to helper

 include/hw/vfio/vfio-common.h         |  10 ++-
 include/hw/vfio/vfio-container-base.h |  16 +---
 hw/vfio/common.c                      | 124 ++++++++++++++++----------
 hw/vfio/container-base.c              |  66 ++++++++------
 hw/vfio/container.c                   | 104 +++++++++++----------
 hw/vfio/iommufd.c                     |  12 +--
 hw/vfio/pci.c                         |   4 +-
 hw/vfio/spapr.c                       |   3 +
 8 files changed, 193 insertions(+), 146 deletions(-)

Comments

Duan, Zhenzhong June 17, 2024, 1:30 a.m. UTC | #1 
Hi Cédric,

>-----Original Message-----
>From: Cédric Le Goater <clg@redhat.com>
>Subject: [PATCH v1 00/16] vfio: QOMify VFIOContainer
>
>Hello,
>
>The series starts with simple changes (patch 1-4). Two of which were
>initialy sent by Joao in a series adding VFIO migration support with
>vIOMMU [1].
>
>The changes following prepare VFIOContainer for QOMification, switch
>the container models to QOM when ready and add some final cleanups.

Except comment on patch 11 and 15,
Others LGTM, so for other patches,

Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>

Thanks
Zhenzhong
Cédric Le Goater June 17, 2024, 5:04 a.m. UTC | #2 
On 6/17/24 3:30 AM, Duan, Zhenzhong wrote:
> Hi Cédric,
> 
>> -----Original Message-----
>> From: Cédric Le Goater <clg@redhat.com>
>> Subject: [PATCH v1 00/16] vfio: QOMify VFIOContainer
>>
>> Hello,
>>
>> The series starts with simple changes (patch 1-4). Two of which were
>> initialy sent by Joao in a series adding VFIO migration support with
>> vIOMMU [1].
>>
>> The changes following prepare VFIOContainer for QOMification, switch
>> the container models to QOM when ready and add some final cleanups.
> 
> Except comment on patch 11 and 15,
> Others LGTM, so for other patches,

yes. I will send a v2 soonish. It is on vfio-9.1
  
> Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>


Thanks,

C.


> 
> Thanks
> Zhenzhong