mbox series

[v4,0/7] qga/commands-posix: replace code duplicating commands with a helper

Message ID 20240320161648.158226-1-andrey.drobyshev@virtuozzo.com
Headers show
Series qga/commands-posix: replace code duplicating commands with a helper | expand

Message

Andrey Drobyshev March 20, 2024, 4:16 p.m. UTC
v3 -> v4:
  * Patch 1/7:
    - Replaced "since 8.3" with "since 9.0" as we're now at v9.0.0-rc0;
    - Renamed the field to 'total-bytes-privileged';
    - Got rid of the implementation details in the docs;
  * Patch 6/7: added g_autoptr macro to local error declaration.

v3: https://lists.nongnu.org/archive/html/qemu-devel/2024-03/msg04068.html

Andrey Drobyshev (7):
  qga: guest-get-fsinfo: add optional 'total-bytes-privileged' field
  qga: introduce ga_run_command() helper for guest cmd execution
  qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper
  qga/commands-posix: qmp_guest_set_time: use ga_run_command helper
  qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper
  qga/commands-posix: don't do fork()/exec() when suspending via sysfs
  qga/commands-posix: qmp_guest_set_user_password: use ga_run_command
    helper

 qga/commands-posix.c | 404 +++++++++++++++++++------------------------
 qga/commands-win32.c |   1 +
 qga/qapi-schema.json |   7 +-
 3 files changed, 187 insertions(+), 225 deletions(-)

Comments

Konstantin Kostiuk April 24, 2024, 9:34 a.m. UTC | #1
To series:

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>


On Wed, Mar 20, 2024 at 6:17 PM Andrey Drobyshev <
andrey.drobyshev@virtuozzo.com> wrote:

> v3 -> v4:
>   * Patch 1/7:
>     - Replaced "since 8.3" with "since 9.0" as we're now at v9.0.0-rc0;
>     - Renamed the field to 'total-bytes-privileged';
>     - Got rid of the implementation details in the docs;
>   * Patch 6/7: added g_autoptr macro to local error declaration.
>
> v3: https://lists.nongnu.org/archive/html/qemu-devel/2024-03/msg04068.html
>
> Andrey Drobyshev (7):
>   qga: guest-get-fsinfo: add optional 'total-bytes-privileged' field
>   qga: introduce ga_run_command() helper for guest cmd execution
>   qga/commands-posix: qmp_guest_shutdown: use ga_run_command helper
>   qga/commands-posix: qmp_guest_set_time: use ga_run_command helper
>   qga/commands-posix: execute_fsfreeze_hook: use ga_run_command helper
>   qga/commands-posix: don't do fork()/exec() when suspending via sysfs
>   qga/commands-posix: qmp_guest_set_user_password: use ga_run_command
>     helper
>
>  qga/commands-posix.c | 404 +++++++++++++++++++------------------------
>  qga/commands-win32.c |   1 +
>  qga/qapi-schema.json |   7 +-
>  3 files changed, 187 insertions(+), 225 deletions(-)
>
> --
> 2.39.3
>
>