| Message ID | 20240307160319.675044-1-dbarboza@ventanamicro.com |
|---|---|
| Headers | show |
| Series | riscv: QEMU RISC-V IOMMU Support | expand |
Hi Daniel, Thanks for the upstream work. Sorry that it took a while for me to review the patchset. Please let me know if you need any help from us to update the IOMMU model. We would like to see it merged for QEMU 9.1.0. Regards, Frank Chang Daniel Henrique Barboza <dbarboza@ventanamicro.com> 於 2024年3月8日 週五 上午12:04寫道： > > Hi, > > This is the second version of the work Tomasz sent in July 2023 [1]. > I'll be helping Tomasz upstreaming it. > > The core emulation code is left unchanged but a few tweaks were made in > v2: > > - The most notable difference in this version is that the code was split > in smaller chunks. Patch 03 is still a 1700 lines patch, which is an > improvement from the 3800 lines patch from v1, but we can only go so > far when splitting the core components of the emulation. The reality > is that the IOMMU emulation is a rather complex piece of software and > there's not much we can do to alleviate it; > > - I'm not contributing the HPM support that was present in v1. It shaved > off 600 lines of code from the series, which is already large enough > as is. We'll introduce HPM in later versions or as a follow-up; > > - The riscv-iommu-header.h header was also trimmed. I shaved it of 300 > or so from it, all of them from definitions that the emulation isn't > using it. The header will be eventually be imported from the Linux > driver (not upstream yet), so for now we can live with a trimmed > header for the emulation usage alone; > > - I added libqos tests for the riscv-iommu-pci device. The idea of these > tests is to give us more confidence in the emulation code; > > - 'edu' device support. The support was retrieved from Tomasz EDU branch > [2]. This device can then be used to test PCI passthrough to exercise > the IOMMU. > > > Patches based on alistair/riscv-to-apply.next. > > v1 link: https://lore.kernel.org/qemu-riscv/cover.1689819031.git.tjeznach@rivosinc.com/ > > [1] https://lore.kernel.org/qemu-riscv/cover.1689819031.git.tjeznach@rivosinc.com/ > [2] https://github.com/tjeznach/qemu.git, branch 'riscv_iommu_edu_impl' > > Andrew Jones (1): > hw/riscv/riscv-iommu: Add another irq for mrif notifications > > Daniel Henrique Barboza (2): > test/qtest: add riscv-iommu-pci tests > qtest/riscv-iommu-test: add init queues test > > Tomasz Jeznach (12): > exec/memtxattr: add process identifier to the transaction attributes > hw/riscv: add riscv-iommu-bits.h > hw/riscv: add RISC-V IOMMU base emulation > hw/riscv: add riscv-iommu-pci device > hw/riscv: add riscv-iommu-sys platform device > hw/riscv/virt.c: support for RISC-V IOMMU PCIDevice hotplug > hw/riscv/riscv-iommu: add Address Translation Cache (IOATC) > hw/riscv/riscv-iommu: add s-stage and g-stage support > hw/riscv/riscv-iommu: add ATS support > hw/riscv/riscv-iommu: add DBG support > hw/misc: EDU: added PASID support > hw/misc: EDU: add ATS/PRI capability > > hw/misc/edu.c | 297 ++++- > hw/riscv/Kconfig | 4 + > hw/riscv/meson.build | 1 + > hw/riscv/riscv-iommu-bits.h | 407 ++++++ > hw/riscv/riscv-iommu-pci.c | 173 +++ > hw/riscv/riscv-iommu-sys.c | 93 ++ > hw/riscv/riscv-iommu.c | 2085 ++++++++++++++++++++++++++++++ > hw/riscv/riscv-iommu.h | 146 +++ > hw/riscv/trace-events | 15 + > hw/riscv/trace.h | 2 + > hw/riscv/virt.c | 33 +- > include/exec/memattrs.h | 5 + > include/hw/riscv/iommu.h | 40 + > meson.build | 1 + > tests/qtest/libqos/meson.build | 4 + > tests/qtest/libqos/riscv-iommu.c | 79 ++ > tests/qtest/libqos/riscv-iommu.h | 96 ++ > tests/qtest/meson.build | 1 + > tests/qtest/riscv-iommu-test.c | 234 ++++ > 19 files changed, 3704 insertions(+), 12 deletions(-) > create mode 100644 hw/riscv/riscv-iommu-bits.h > create mode 100644 hw/riscv/riscv-iommu-pci.c > create mode 100644 hw/riscv/riscv-iommu-sys.c > create mode 100644 hw/riscv/riscv-iommu.c > create mode 100644 hw/riscv/riscv-iommu.h > create mode 100644 hw/riscv/trace-events > create mode 100644 hw/riscv/trace.h > create mode 100644 include/hw/riscv/iommu.h > create mode 100644 tests/qtest/libqos/riscv-iommu.c > create mode 100644 tests/qtest/libqos/riscv-iommu.h > create mode 100644 tests/qtest/riscv-iommu-test.c > > -- > 2.43.2 > >
On 5/10/24 08:14, Frank Chang wrote: > Hi Daniel, > > Thanks for the upstream work. > Sorry that it took a while for me to review the patchset. > > Please let me know if you need any help from us to update the IOMMU model. > We would like to see it merged for QEMU 9.1.0. Thanks for the help in the reviews! I'll do some last changes in the riscv-iommu-pci device, and check if we have any DT changes that happened that we need to sync up. The plan is to send v3 in the next couple of days. Let's see how it goes. Thanks, Daniel > > Regards, > Frank Chang > > Daniel Henrique Barboza <dbarboza@ventanamicro.com> 於 2024年3月8日 週五 上午12:04寫道： >> >> Hi, >> >> This is the second version of the work Tomasz sent in July 2023 [1]. >> I'll be helping Tomasz upstreaming it. >> >> The core emulation code is left unchanged but a few tweaks were made in >> v2: >> >> - The most notable difference in this version is that the code was split >> in smaller chunks. Patch 03 is still a 1700 lines patch, which is an >> improvement from the 3800 lines patch from v1, but we can only go so >> far when splitting the core components of the emulation. The reality >> is that the IOMMU emulation is a rather complex piece of software and >> there's not much we can do to alleviate it; >> >> - I'm not contributing the HPM support that was present in v1. It shaved >> off 600 lines of code from the series, which is already large enough >> as is. We'll introduce HPM in later versions or as a follow-up; >> >> - The riscv-iommu-header.h header was also trimmed. I shaved it of 300 >> or so from it, all of them from definitions that the emulation isn't >> using it. The header will be eventually be imported from the Linux >> driver (not upstream yet), so for now we can live with a trimmed >> header for the emulation usage alone; >> >> - I added libqos tests for the riscv-iommu-pci device. The idea of these >> tests is to give us more confidence in the emulation code; >> >> - 'edu' device support. The support was retrieved from Tomasz EDU branch >> [2]. This device can then be used to test PCI passthrough to exercise >> the IOMMU. >> >> >> Patches based on alistair/riscv-to-apply.next. >> >> v1 link: https://lore.kernel.org/qemu-riscv/cover.1689819031.git.tjeznach@rivosinc.com/ >> >> [1] https://lore.kernel.org/qemu-riscv/cover.1689819031.git.tjeznach@rivosinc.com/ >> [2] https://github.com/tjeznach/qemu.git, branch 'riscv_iommu_edu_impl' >> >> Andrew Jones (1): >> hw/riscv/riscv-iommu: Add another irq for mrif notifications >> >> Daniel Henrique Barboza (2): >> test/qtest: add riscv-iommu-pci tests >> qtest/riscv-iommu-test: add init queues test >> >> Tomasz Jeznach (12): >> exec/memtxattr: add process identifier to the transaction attributes >> hw/riscv: add riscv-iommu-bits.h >> hw/riscv: add RISC-V IOMMU base emulation >> hw/riscv: add riscv-iommu-pci device >> hw/riscv: add riscv-iommu-sys platform device >> hw/riscv/virt.c: support for RISC-V IOMMU PCIDevice hotplug >> hw/riscv/riscv-iommu: add Address Translation Cache (IOATC) >> hw/riscv/riscv-iommu: add s-stage and g-stage support >> hw/riscv/riscv-iommu: add ATS support >> hw/riscv/riscv-iommu: add DBG support >> hw/misc: EDU: added PASID support >> hw/misc: EDU: add ATS/PRI capability >> >> hw/misc/edu.c | 297 ++++- >> hw/riscv/Kconfig | 4 + >> hw/riscv/meson.build | 1 + >> hw/riscv/riscv-iommu-bits.h | 407 ++++++ >> hw/riscv/riscv-iommu-pci.c | 173 +++ >> hw/riscv/riscv-iommu-sys.c | 93 ++ >> hw/riscv/riscv-iommu.c | 2085 ++++++++++++++++++++++++++++++ >> hw/riscv/riscv-iommu.h | 146 +++ >> hw/riscv/trace-events | 15 + >> hw/riscv/trace.h | 2 + >> hw/riscv/virt.c | 33 +- >> include/exec/memattrs.h | 5 + >> include/hw/riscv/iommu.h | 40 + >> meson.build | 1 + >> tests/qtest/libqos/meson.build | 4 + >> tests/qtest/libqos/riscv-iommu.c | 79 ++ >> tests/qtest/libqos/riscv-iommu.h | 96 ++ >> tests/qtest/meson.build | 1 + >> tests/qtest/riscv-iommu-test.c | 234 ++++ >> 19 files changed, 3704 insertions(+), 12 deletions(-) >> create mode 100644 hw/riscv/riscv-iommu-bits.h >> create mode 100644 hw/riscv/riscv-iommu-pci.c >> create mode 100644 hw/riscv/riscv-iommu-sys.c >> create mode 100644 hw/riscv/riscv-iommu.c >> create mode 100644 hw/riscv/riscv-iommu.h >> create mode 100644 hw/riscv/trace-events >> create mode 100644 hw/riscv/trace.h >> create mode 100644 include/hw/riscv/iommu.h >> create mode 100644 tests/qtest/libqos/riscv-iommu.c >> create mode 100644 tests/qtest/libqos/riscv-iommu.h >> create mode 100644 tests/qtest/riscv-iommu-test.c >> >> -- >> 2.43.2 >> >>