mbox series

[v7,0/3] string list functions

Message ID 20240227153321.467343-1-armbru@redhat.com
Headers show
Series string list functions | expand

Message

Markus Armbruster Feb. 27, 2024, 3:33 p.m. UTC 
This is Steve's work (v1 to v5), tweaked by Philippe (v6), and now by
me.

v7:
* Old PATCH 1 dropped
  The proposed str_split() is a composition of g_strsplit() and a
  conversion from char ** to strList *.  I'm willing to accept a
  conversion function str_list_from_strv() next to
  strv_from_str_list().  I doubt having a function for the composition
  is worth the trouble.
* Old PATCH 4 dropped
  The tests mostly test g_strsplit().  I'm willing to accept focused
  tests for strv_from_str_list() and str_list_from_strv().
* PATCH 1-3: Commit messages tweaked
* PATCH 2: strv_from_strList() renamed strv_from_str_list(), and moved
  to qapi/qapi-type-helpers.c.  Function comment tweaked.  Local
  variable @argv renamed to @strv.
* PATCH 3: Adjust for the rename.

Steve Sistare (3):
  qapi: New QAPI_LIST_LENGTH()
  qapi: New strv_from_str_list()
  migration: simplify exec migration functions

 include/qapi/type-helpers.h |  8 ++++++
 include/qapi/util.h         | 13 +++++++++
 migration/exec.c            | 57 ++++++-------------------------------
 qapi/qapi-type-helpers.c    | 14 +++++++++
 4 files changed, 43 insertions(+), 49 deletions(-)

Comments

Steven Sistare Feb. 27, 2024, 4:21 p.m. UTC | #1 
All the changes look good - steve

On 2/27/2024 10:33 AM, Markus Armbruster wrote:
> This is Steve's work (v1 to v5), tweaked by Philippe (v6), and now by
> me.
> 
> v7:
> * Old PATCH 1 dropped
>   The proposed str_split() is a composition of g_strsplit() and a
>   conversion from char ** to strList *.  I'm willing to accept a
>   conversion function str_list_from_strv() next to
>   strv_from_str_list().  I doubt having a function for the composition
>   is worth the trouble.
> * Old PATCH 4 dropped
>   The tests mostly test g_strsplit().  I'm willing to accept focused
>   tests for strv_from_str_list() and str_list_from_strv().
> * PATCH 1-3: Commit messages tweaked
> * PATCH 2: strv_from_strList() renamed strv_from_str_list(), and moved
>   to qapi/qapi-type-helpers.c.  Function comment tweaked.  Local
>   variable @argv renamed to @strv.
> * PATCH 3: Adjust for the rename.
> 
> Steve Sistare (3):
>   qapi: New QAPI_LIST_LENGTH()
>   qapi: New strv_from_str_list()
>   migration: simplify exec migration functions
> 
>  include/qapi/type-helpers.h |  8 ++++++
>  include/qapi/util.h         | 13 +++++++++
>  migration/exec.c            | 57 ++++++-------------------------------
>  qapi/qapi-type-helpers.c    | 14 +++++++++
>  4 files changed, 43 insertions(+), 49 deletions(-)
>
Markus Armbruster March 1, 2024, 11:54 a.m. UTC | #2 
Steven Sistare <steven.sistare@oracle.com> writes:

> All the changes look good - steve

Thanks!

I can stick this into my next PR, ETA early next week.