mbox series

[0/2] backends/iommufd: Remove mutex

Message ID 20240102123210.1184293-1-clg@redhat.com
Headers show
Series backends/iommufd: Remove mutex | expand

Message

Cédric Le Goater Jan. 2, 2024, 12:32 p.m. UTC 
Hello !

Coverity has some reports regarding the IOMMUFDBackend mutex. Since
the IOMMUFDBackend routines are called from the QEMU main thread, this
series simply suggests removing the mutex and rely on the BQL to
handle concurrent access.

Thanks,

C.

Cédric Le Goater (2):
  backends/iommufd: Remove check on number of backend users
  backends/iommufd: Remove mutex

 include/sysemu/iommufd.h |  2 --
 backends/iommufd.c       | 12 ------------
 2 files changed, 14 deletions(-)

Comments

Eric Auger Jan. 2, 2024, 2:37 p.m. UTC | #1 
Hi Cédric,

On 1/2/24 13:32, Cédric Le Goater wrote:
> Hello !
>
> Coverity has some reports regarding the IOMMUFDBackend mutex. Since
> the IOMMUFDBackend routines are called from the QEMU main thread, this
> series simply suggests removing the mutex and rely on the BQL to
> handle concurrent access.
>
> Thanks,
>
> C.
>
> Cédric Le Goater (2):
>   backends/iommufd: Remove check on number of backend users
>   backends/iommufd: Remove mutex

for the series:
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thank you for the fix!

Eric
>
>  include/sysemu/iommufd.h |  2 --
>  backends/iommufd.c       | 12 ------------
>  2 files changed, 14 deletions(-)
>
Duan, Zhenzhong Jan. 4, 2024, 1:55 a.m. UTC | #2 
>-----Original Message-----
>From: Cédric Le Goater <clg@redhat.com>
>Sent: Tuesday, January 2, 2024 8:32 PM
>To: qemu-devel@nongnu.org
>Cc: Liu, Yi L <yi.l.liu@intel.com>; Eric Auger <eric.auger@redhat.com>; Duan,
>Zhenzhong <zhenzhong.duan@intel.com>; Cédric Le Goater
><clg@redhat.com>
>Subject: [PATCH 0/2] backends/iommufd: Remove mutex
>
>Hello !
>
>Coverity has some reports regarding the IOMMUFDBackend mutex. Since
>the IOMMUFDBackend routines are called from the QEMU main thread, this
>series simply suggests removing the mutex and rely on the BQL to
>handle concurrent access.

For the whole series,
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>

Thanks
Zhenzhong

>
>Thanks,
>
>C.
>
>Cédric Le Goater (2):
>  backends/iommufd: Remove check on number of backend users
>  backends/iommufd: Remove mutex
>
> include/sysemu/iommufd.h |  2 --
> backends/iommufd.c       | 12 ------------
> 2 files changed, 14 deletions(-)
>
>--
>2.43.0
Cédric Le Goater Jan. 4, 2024, 8:41 a.m. UTC | #3 
On 1/2/24 13:32, Cédric Le Goater wrote:
> Hello !
> 
> Coverity has some reports regarding the IOMMUFDBackend mutex. Since
> the IOMMUFDBackend routines are called from the QEMU main thread, this
> series simply suggests removing the mutex and rely on the BQL to
> handle concurrent access.
> 
> Thanks,
> 
> C.
> 
> Cédric Le Goater (2):
>    backends/iommufd: Remove check on number of backend users
>    backends/iommufd: Remove mutex
> 
>   include/sysemu/iommufd.h |  2 --
>   backends/iommufd.c       | 12 ------------
>   2 files changed, 14 deletions(-)
> 


Applied to vfio-next.

Thanks,

C.