From patchwork Thu Dec 21 15:07:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernhard Beschow X-Patchwork-Id: 1879224 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=hxXMYZB4; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Swv426Dcxz1ydg for ; Fri, 22 Dec 2023 02:09:54 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGKew-0008H3-7h; Thu, 21 Dec 2023 10:08:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGKel-00089L-71; Thu, 21 Dec 2023 10:08:15 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rGKea-0004I4-0v; Thu, 21 Dec 2023 10:08:13 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-553729ee917so1044326a12.1; Thu, 21 Dec 2023 07:08:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703171281; x=1703776081; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MWGJZ0Gsl+PYUoTMm4hN3Tlx09gBayWoo98VZLx9eew=; b=hxXMYZB4TMNw820KAnqs8clXAKu5RtsjTnJkb74KMu5P94uPMC/2qb3I5bu38rQm1+ G2Lwo+AOQhZ/sGfIfwcVXOxeHKQcXmJdHSVjYJrgdl3oD2dvl107LOTt7oukdI8RUJu/ K4lf6hUZ0l1oZ5CdwCby6mq2HFTSm5wTjcdm0XT/OREliL6fQphEdSqVE/HcqotDjGWk t6Bkeoue9wmycqEtVPe1DQRecw/PkMaZxCBMIborkcWHNr2+x3dImAaciksmn52SWYgq mvHrGHAMChsBaH3WN4hu60MJ/1OJdKs3/FIc+j9CjcJcU/jmIMX5c8MIww/dqE7QK3JF 1JtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703171281; x=1703776081; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MWGJZ0Gsl+PYUoTMm4hN3Tlx09gBayWoo98VZLx9eew=; b=xFzCAGgj3h35bOd0HE6gOEvPIDZ1Y0Mx8nx4FG9C5U67hYVoUaCOZaKsxte3LOggqE jhoWl6vp+MF7VFSxpZ9Dy5IY1/yerjB+cuvkLl1eMLA7p8Z/2CxAWKRZBOQVw619/jZT wtd1CXQ5g1ge+Gx4m2EEIeOM9UUXBky0klIo4c41fSfTR6uA61n2aUXO/DPPi3m2nZ6T kEPpvR41z/C3Wz/W0d1HD2iMLo92QImRFJpB1GNHcaf4KK6cEssH/eTV4qVGbOPndSp2 YDNvt9deRQPTuRC//S6rzmhryx7VQnXycsx1S9ALQhVqSq9v6KSN02ILi8aLp731GzhR OuHg== X-Gm-Message-State: AOJu0YxSQoNhOSKPlR3Pu6w6NvsSWjWx82mSCHaiv/nM0aGw/Q3l3LVn yyEN4Bze2k1Oiwtg0K8y3JId6J7SGjg= X-Google-Smtp-Source: AGHT+IHRBMBufEku5BHMb1lY3bU9Xh+3rohcmaTON3R8ykmyf7polaItQmpBPgtXLHvdoUzij57QYA== X-Received: by 2002:a50:8dc5:0:b0:54c:f1cd:1a9 with SMTP id s5-20020a508dc5000000b0054cf1cd01a9mr11205051edh.39.1703171280768; Thu, 21 Dec 2023 07:08:00 -0800 (PST) Received: from archlinux.. (pd95ed842.dip0.t-ipconnect.de. [217.94.216.66]) by smtp.gmail.com with ESMTPSA id t25-20020a056402241900b00553b6b5bb44sm1264264eda.67.2023.12.21.07.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 07:08:00 -0800 (PST) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Juan Quintela , =?utf-8?q?Herv=C3=A9_Poussineau?= , Hanna Reitz , Fabiano Rosas , Paolo Bonzini , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Mark Cave-Ayland , Aleksandar Rikalo , =?utf-8?q?Philippe_Mathie?= =?utf-8?q?u-Daud=C3=A9?= , Eduardo Habkost , Thomas Huth , Peter Xu , Jiaxun Yang , qemu-ppc@nongnu.org, Kevin Wolf , =?utf-8?b?RnLDqWTDqXJp?= =?utf-8?b?YyBCYXJyYXQ=?= , Sergio Lopez , John Snow , Artyom Tarasenko , David Hildenbrand , Nicholas Piggin , Marcel Apfelbaum , BALATON Zoltan , qemu-block@nongnu.org, Richard Henderson , Leonardo Bras , "Michael S. Tsirkin" , Bernhard Beschow Subject: [PATCH v3 00/11] hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions Date: Thu, 21 Dec 2023 16:07:39 +0100 Message-ID: <20231221150750.5435-1-shentey@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=shentey@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This series implements relocation of the SuperI/O functions of the VIA south bridges which resolves some FIXME's. It is part of my via-apollo-pro-133t branch [1] which is an extension of bringing the VIA south bridges to the PC machine [2]. This branch is able to run some real-world X86 BIOSes in the hope that it allows us to form a better understanding of the real vt82c686b devices. Implementing relocation and toggling of the SuperI/O functions is one step to make these BIOSes run without error messages, so here we go. The series is structured as follows: Patches 1-3 prepare the TYPE_ISA_FDC, TYPE_ISA_PARALLEL and TYPE_ISA_SERIAL to relocate and toggle (enable/disable) themselves without breaking encapsulation of their respective device states. This is achieved by moving the MemoryRegions and PortioLists from the device states into the encapsulating ISA devices since they will be relocated and toggled. Inspired by the memory API patches 4-6 add two convenience functions to the portio_list API to toggle and relocate portio lists. Patch 5 is a preparation for that which removes some redundancies which otherwise had to be dealt with during relocation. Patches 7-9 implement toggling and relocation for types TYPE_ISA_FDC, TYPE_ISA_PARALLEL and TYPE_ISA_SERIAL. Patch 10 prepares the pegasos2 machine which would end up with all SuperI/O functions disabled if no -bios argument is given. Patch 11 finally implements the main feature which now relies on firmware to configure the SuperI/O functions accordingly (except for pegasos2). v3: * Rework various commit messages (Zoltan) * Drop patch "hw/char/serial: Free struct SerialState from MemoryRegion" (Zoltan) * Generalize wording in migration.rst to include portio_list API (Zoltan) v2: * Improve commit message (Zoltan) * Split pegasos2 from vt82c686 patch (Zoltan) * Avoid poking into device internals (Zoltan) Testing done: * make check * make check-avocado * Run MorphOS on pegasos2 with and without pegasos2.rom * Run Linux on amigaone * Run real-world BIOSes on via-apollo-pro-133t branch * Start rescue-yl on fuloong2e [1] https://github.com/shentok/qemu/tree/via-apollo-pro-133t [2] https://github.com/shentok/qemu/tree/pc-via Bernhard Beschow (11): hw/block/fdc-isa: Move portio_list from FDCtrl to FDCtrlISABus hw/block/fdc-sysbus: Move iomem from FDCtrl to FDCtrlSysBus hw/char/parallel: Move portio_list from ParallelState to ISAParallelState exec/ioport: Resolve redundant .base attribute in struct MemoryRegionPortio exec/ioport: Add portio_list_set_address() exec/ioport: Add portio_list_set_enabled() hw/block/fdc-isa: Implement relocation and enabling/disabling for TYPE_ISA_FDC hw/char/serial-isa: Implement relocation and enabling/disabling for TYPE_ISA_SERIAL hw/char/parallel-isa: Implement relocation and enabling/disabling for TYPE_ISA_PARALLEL hw/ppc/pegasos2: Let pegasos2 machine configure SuperI/O functions hw/isa/vt82c686: Implement relocation and toggling of SuperI/O functions docs/devel/migration.rst | 6 +- hw/block/fdc-internal.h | 4 -- include/exec/ioport.h | 4 +- include/hw/block/fdc.h | 3 + include/hw/char/parallel-isa.h | 5 ++ include/hw/char/parallel.h | 2 - include/hw/char/serial.h | 2 + hw/block/fdc-isa.c | 18 +++++- hw/block/fdc-sysbus.c | 6 +- hw/char/parallel-isa.c | 14 ++++ hw/char/parallel.c | 2 +- hw/char/serial-isa.c | 14 ++++ hw/isa/vt82c686.c | 115 ++++++++++++++++++++++++--------- hw/ppc/pegasos2.c | 15 +++++ system/ioport.c | 41 ++++++++++-- 15 files changed, 200 insertions(+), 51 deletions(-)