mbox series

[v2,00/11] next-cube: various tidy-ups and improvements

Message ID 20231220131641.592826-1-mark.cave-ayland@ilande.co.uk
Headers show
Series next-cube: various tidy-ups and improvements | expand

Message

Mark Cave-Ayland Dec. 20, 2023, 1:16 p.m. UTC 
This series contains some tidy-ups/improvements for the next-cube machine with
the aim of bringing the code up-to-date with our latest coding guidelines.

The main aim of the series is to bring the memory accessors up-to-date with
the memory API and improve some of basic machine modelling. There are still
some future improvements that can be made: for example switching from DPRINTF
macros to trace events and proper modelling of the DMA controller, however
I've left these for now since they allow for easier comparison with Bryce's
original GSoC branch.

This series can be used in conjunction with my upcoming ESP rework series
which fixes up the ESP emulation enough to allow the next-cube machine to
load a kernel from disk and start executing it.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

[Patches missing R-B: 1, 8, 9, 10]

v2:
- Add R-B and T-B tags from Thomas
- Swap patches 8 and 9 ("next-cube.c: move LED logic to new
  next_scr2_led_update() function") and ("next-cube.c: move static old_scr2
  variable to NeXTPC") to maintain bisectibility
- Drop patch 11 ("next-cube.c: replace sysmem with get_system_memory() in
  next_cube_init()")


Mark Cave-Ayland (11):
  next-cube.c: add dummy Ethernet register to allow diagnostic to
    timeout
  next-cube.c: don't pulse SCSI DMA IRQ upon reception of FLUSH command
  next-cube.c: update mmio_ops to properly use modern memory API
  next-cube.c: update scr_ops to properly use modern memory API
  next-cube.c: update and improve dma_ops
  next-cube.c: move static led variable to NeXTPC
  next-cube.c: move static phase variable to NextRtc
  next-cube.c: move static old_scr2 variable to NeXTPC
  next-cube.c: move LED logic to new next_scr2_led_update() function
  next-cube.c: remove val and size arguments from nextscr2_write()
  next-cube.c: move machine MemoryRegions into NeXTState

 hw/m68k/next-cube.c | 525 +++++++++++++++++++-------------------------
 1 file changed, 227 insertions(+), 298 deletions(-)